fix: preserve undo history when selecting @ mention autocompletion #8311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use document.execCommand("insertText") instead of directly setting input value
- This preserves the browser undo/redo stack, allowing Ctrl+Z to undo autocompletion
- Follows the same pattern already used for enhanced prompt feature
- Fixes #8310
2 tasks
dosubot
bot
added
the
size:S
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if (document.execCommand) { | ||
| // Focus the textarea to ensure it's the active element | ||
| textAreaRef.current.focus() | ||
|
|
Contributor
Author
There was a problem hiding this comment.
P1: document.execCommand('insertText') return value is not checked. If it returns false (no exception), the DOM may not change and no input event fires, leaving state unchanged. Please fall back to setInputValue(newValue) when execCommand returns false.
| textAreaRef.current.value, | ||
| cursorPosition, | ||
| insertValue, | ||
| isSlashCommand, |
Contributor
Author
There was a problem hiding this comment.
P2: This execCommand-based insertion duplicates the enhancedPrompt path nearby. Consider extracting a helper (e.g., insertTextPreservingUndo) to DRY the focus/select/execCommand + fallback flow.
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Closing as stale |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where users couldn't use Ctrl+Z to undo @ mention autocompletion in the chat text area.
Problem
When a user types '@' and selects something from the autocompletion dropdown, pressing Ctrl+Z doesn't undo the autocompletion. Users had to manually delete the autocompleted text, which was inconvenient.
Solution
Modified the
handleMentionSelectfunction inChatTextArea.tsxto usedocument.execCommand('insertText')instead of directly setting the input value. This preserves the browser's native undo/redo stack, allowing Ctrl+Z to properly undo the autocompletion.The implementation:
Testing
Related Issue
Fixes #8310
Review Confidence
Implementation review showed 95% confidence with no security concerns or breaking changes.
Feedback and guidance are welcome!
Important
Fixes undo history preservation for @ mention autocompletion in
ChatTextArea.tsxby usingdocument.execCommand('insertText').ChatTextArea.tsx.handleMentionSelectto usedocument.execCommand('insertText')for text insertion, preserving undo history.execCommandfails or is unavailable.execCommandis unavailable.This description was created by
for 287ec58. You can customize this summary. It will automatically update as commits are pushed.