Skip to content

feat: log out from cloud when resetting extension state #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

feat: log out from cloud when resetting extension state #8312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac2d5ae
feat: log out from cloud when resetting extension state
roomote Sep 25, 2025
ea8420b
Remove file
mrubens Sep 25, 2025
4aa549a
Call logout more indiscriminately
mrubens Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .tmp/Roo-Code
Open in desktop
Submodule Roo-Code added at 86debe
12 changes: 12 additions & 0 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2255,6 +2255,18 @@ export class ClineProvider
return
}

// Log out from cloud if authenticated
if (CloudService.hasInstance() && CloudService.instance.isAuthenticated()) {
Copy link
Contributor Author

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Consider using hasActiveSession() instead of isAuthenticated() to decide whether to logout. This better reflects the condition that a session exists and avoids coupling to auth semantics that may require initialization states.

Suggested change
if (CloudService.hasInstance() && CloudService.instance.isAuthenticated()) {
if (CloudService.hasInstance() && CloudService.instance.hasActiveSession()) {

Copy link
Collaborator

@mrubens mrubens Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (CloudService.hasInstance() && CloudService.instance.isAuthenticated()) {
if (CloudService.hasInstance()) {

try {
await CloudService.instance.logout()
} catch (error) {
this.log(
`Failed to logout from cloud during reset: ${error instanceof Error ? error.message : String(error)}`,
)
// Continue with reset even if logout fails
}
}

await this.contextProxy.resetAllState()
await this.providerSettingsManager.resetAllConfigs()
await this.customModesManager.resetCustomModes()
Expand Down
Loading