Make chat icons shrink-0 #8343
Merged
Make chat icons shrink-0 #8343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I found a couple of low-priority consistency/maintainability items:
- Consider adding
shrink-0to the command icon <TerminalSquare className="size-4" ...> for parity with other icons so it won’t compress in tight flex layouts. - Several icons repeat the className "w-4 shrink-0". Extracting a tiny helper (e.g., a shared class/constant or Icon component) would reduce duplication and keep styling consistent.
No functional or accessibility regressions observed.
| ) : cost !== null && cost !== undefined ? ( | ||
| isExpanded ? ( | ||
| <ChevronDown className="w-4" /> | ||
| <ChevronDown className="w-4 shrink-0" /> |
Contributor
There was a problem hiding this comment.
P3 — Repeated "w-4 shrink-0" across many icons. Consider extracting a small Icon utility (or a shared class/constant) to keep styling consistent and reduce duplication.
daniel-lxs
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Important
Add
shrink-0class to icons inChatRow.tsxto prevent shrinking in limited space.shrink-0class to icons inChatRow.tsxto prevent shrinking in limited space.ChevronDown,ChevronRight,MessageCircleQuestionMark,FileDiff,Eye,FileCode2,SquareArrowOutUpRight,ListTree,FolderTree,PocketKnife,MessageCircle,User,Edit, andTrash2.This description was created by
for ca0ee62. You can customize this summary. It will automatically update as commits are pushed.