fix: ensure sourcemap references use correct .js.map extension #8345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified sourcemapPlugin to detect and fix incorrect sourcemap references - Ensures all JavaScript files reference .js.map files instead of .sourcemap - Fixes issue where checkpoint restore buttons were not displaying due to sourcemap loading errors Fixes #8344
dosubot
bot
added
size:S
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Self-review: auditing my own code is like linting a mirror—reflective, pedantic, and slightly unsettling.
Summary:
- P1: Unintended gitlinks added (.review/pr-8274, tmp/pr-8287-Roo-Code). Please remove from the PR; consider .gitignore if needed.
- P2: Don’t overwrite inline data URL sourcemaps; guard with currentMapRef.startsWith("data:").
- P3: Prefer atomic writes for JSON maps (tmp + rename) to avoid partial writes.
| // Check if the source map is already referenced | ||
| if (!jsContent.includes("//# sourceMappingURL=")) { | ||
| // Check if the source map is already referenced or has incorrect reference | ||
| const sourceMappingURLRegex = /\/\/# sourceMappingURL=([^\s\n]+)/ |
Contributor
Author
There was a problem hiding this comment.
P3: Regex robustness: anchor to the line and use multiline to avoid partial matches.
Suggested change
| const sourceMappingURLRegex = /\/\/# sourceMappingURL=([^\s\n]+)/ | |
| const sourceMappingURLRegex = /^\/\/# sourceMappingURL=(.+)$/m |
| const currentMapRef = match[1] | ||
| const expectedMapRef = `${jsFile}.map` | ||
|
|
||
| if (currentMapRef !== expectedMapRef) { |
Contributor
Author
There was a problem hiding this comment.
P2: Avoid overwriting inline data URL sourcemaps (data:...). Guard before replacing.
Suggested change
| if (currentMapRef !== expectedMapRef) { | |
| if (!currentMapRef.startsWith("data:") && currentMapRef !== expectedMapRef) { |
Member
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where sourcemap references were using incorrect file extensions (e.g.,
index.sourcemapinstead ofindex.js.map), which prevented checkpoint restore buttons from displaying when hovering over checkpoint lines.Problem
index.sourcemapinstead ofindex.js.mapSolution
Modified the
sourcemapPluginto:.sourcemap→.js.map)Changes
webview-ui/src/vite-plugins/sourcemapPlugin.tsto detect and fix incorrect sourcemap references.js.mapfiles correctlyTesting
Related Issue
Fixes #8344
Review Confidence
The implementation review showed 92% confidence with no security issues and good code quality adherence.
Future Improvements
Consider adding unit tests for the sourcemap plugin to ensure the fix works correctly across all scenarios.
Important
Fixes sourcemap references in
sourcemapPlugin.tsto ensure.js.mapextension is used, resolving checkpoint restore issues.sourcemapPlugin.tsto use.js.mapextension instead of.sourcemap..js.mapextension.This description was created by
for f872000. You can customize this summary. It will automatically update as commits are pushed.