fix: ensure Roo provider yields text content to prevent blank UI responses #8349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onses - Added logic to yield empty text chunk when only reasoning content is received - This prevents the UI from showing blank responses for models that only output thinking/reasoning - Fixes issue #8348 where Supernova and other free Roo Cloud models showed blank responses
dosubot
bot
added
size:XL
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
|
|
||
| // If we only received reasoning content and no text content, yield an empty text chunk | ||
| // This ensures the UI doesn't show a blank response | ||
| if (!hasYieldedContent) { |
Contributor
Author
There was a problem hiding this comment.
P2 — Ordering UX: when the stream contains only usage (no text) the current implementation yields the usage chunk first and the empty text chunk afterward. This can keep the UI blank until the very end. Consider emitting an empty text chunk right before usage when no text has been yielded yet.
Suggested change
| if (!hasYieldedContent) { | |
| if (chunk.usage) { | |
| if (!hasYieldedContent) { | |
| yield { | |
| type: "text", | |
| text: "", | |
| } | |
| hasYieldedContent = true | |
| } | |
| yield { | |
| type: "usage", | |
| inputTokens: chunk.usage.prompt_tokens || 0, | |
| outputTokens: chunk.usage.completion_tokens || 0, | |
| } | |
| } |
| metadata?.taskId ? { headers: { "X-Roo-Task-ID": metadata.taskId } } : undefined, | ||
| ) | ||
|
|
||
| let hasYieldedContent = false |
Contributor
Author
There was a problem hiding this comment.
P3 — Minor clarity: add a comment clarifying that reasoning-only output should not count as content for avoiding blank UI responses.
Suggested change
| let hasYieldedContent = false | |
| // Tracks if any text content has been emitted; reasoning-only output doesn't count | |
| let hasYieldedContent = false |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #8348 where Supernova and other free Roo Cloud models were showing blank responses in the UI when they only returned reasoning/thinking content without actual text content.
Problem
When certain Roo Cloud models (like Supernova) only return reasoning content without text content, the UI would appear blank because no text chunks were being yielded to the stream.
Solution
Modified the Roo provider to track whether any text content has been yielded during streaming. If no text content was yielded by the end of the stream (only reasoning was received), an empty text chunk is yielded to ensure the UI has something to display.
Changes
hasYieldedContentflag insrc/api/providers/roo.tsto track if text content was yieldedTesting
Related Issues
Fixes #8348
Review Confidence
The implementation review showed 95% confidence with no security issues or convention violations.
Feedback and guidance are welcome!
Important
Fixes issue #8348 by ensuring Roo provider yields an empty text chunk if no text content is present, preventing blank UI responses.
roo.ts, addedhasYieldedContentflag to track if text content is yielded increateMessage().roo.spec.tsto cover scenarios where only reasoning content is received, actual text content is received, and completely empty streams.This description was created by
for 1b0e3d9. You can customize this summary. It will automatically update as commits are pushed.