-
Notifications
You must be signed in to change notification settings - Fork 2.5k
web: Testimonials #8360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Testimonials #8360
Conversation
| <div className="mx-auto mb-8 md:max-w-2xl text-center"> | ||
| <h2 className="text-4xl font-bold tracking-tight sm:text-5xl"> | ||
| AI-forward developers are using Roo Code | ||
| Developers <em>really</em> shipping with AI are using Roo Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User-facing text (e.g., heading and subheading) should be internationalized using a translation function instead of hard-coded strings.
| Developers <em>really</em> shipping with AI are using Roo Code | |
| {t('Developers <em>really</em> shipping with AI are using Roo Code')} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention. Inline comments cover stable keys and accessibility for star ratings. Additionally, please verify the Embla autoplay re-init handler: emblaApi.plugins().autoplay is the correct accessor; current code uses autoPlay which stays undefined.
| <div | ||
| key={testimonial.id} | ||
| className="relative min-w-0 flex-[0_0_85%] px-2 md:flex-[0_0_70%] md:px-4 lg:flex-[0_0_60%]"> | ||
| key={testimonial.name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: The list key uses only 'name'. Consider composing a more stable key (e.g., name + origin) to avoid collisions.
| <p className="text-sm text-muted-foreground transition-colors duration-300 dark:text-muted-foreground/80"> | ||
| {testimonial.role} at {testimonial.company} | ||
| {testimonial.role} at {testimonial.origin} | ||
| {testimonial.stars && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Accessibility — expose rating to screen readers (aria-label on the container) and hide decorative icons (aria-hidden on each star).
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-qk7wbzhet-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
Important
Enhance testimonials section with more entries, star ratings, and visual tweaks in
testimonials.tsx.testimonials.tsx, including star ratings for some entries.companyfield toorigininTestimonialinterface.Testimonials().Testimonials().This description was created by
for 4eb4533. You can customize this summary. It will automatically update as commits are pushed.