-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: update Vertex AI Claude Sonnet 4.5 model identifier #8389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add new model identifier 'claude-sonnet-4-5@20250929' as used by Vertex AI - Keep deprecated 'claude-4.5-sonnet' for backward compatibility with deprecation comment - Fixes issue where Vertex AI returns 404 for Claude Sonnet 4.5 requests Fixes #8387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review initiated: debating with myself over stray submodules like a git-spirited identity crisis.
| @@ -0,0 +1 @@ | |||
| Subproject commit 8dbd8c4b1b72fb48be3990a8e78285a787a1828c | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Unintended submodule/gitlink tracked in the repo. This looks like a tooling artifact and should not be committed. Please remove this file from the PR and ensure .gitignore excludes .tmp/ if appropriate.
| @@ -0,0 +1 @@ | |||
| Subproject commit b832e9253d2e62b4ce9e10a7a9a0f8d0263c3490 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Unintended submodule/gitlink tracked in the repo. Please remove this from the PR and consider ignoring .work/ to avoid committing transient artifacts.
| @@ -0,0 +1 @@ | |||
| Subproject commit ea8420be8c5386d867fe6aa7b1f9756a44a3b5b1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Unintended submodule/gitlink tracked in the repo. Please remove this from the PR; these are ephemeral review artifacts that shouldn't be versioned.
| export const vertexDefaultModelId: VertexModelId = "claude-sonnet-4@20250514" | ||
|
|
||
| export const vertexModels = { | ||
| // Deprecated: Use claude-sonnet-4-5@20250929 instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Consider documenting a deprecation timeline (e.g., removal date or next minor release) for "claude-4.5-sonnet" to clarify when this legacy ID will be dropped.
Description
This PR attempts to address Issue #8387. Feedback and guidance are welcome.
Problem
Users of Claude Sonnet 4.5 with Google Vertex AI Provider were receiving a 404 error:
Solution
claude-sonnet-4-5@20250929as used by Vertex AIclaude-4.5-sonnetidentifier for backward compatibility with a deprecation commentTesting
Notes
Fixes #8387
Important
Update Claude Sonnet 4.5 model identifier in
vertex.tsto fix 404 error, retaining old identifier for backward compatibility.claude-sonnet-4-5@20250929invertex.ts.claude-4.5-sonnetidentifier with deprecation notice for backward compatibility.This description was created by
for 74450f5. You can customize this summary. It will automatically update as commits are pushed.