Skip to content

Include reasoning messages in cloud tasks #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

Include reasoning messages in cloud tasks #8401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,6 +2252,22 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// Note: updateApiReqMsg() is now called from within drainStreamInBackgroundToFindAllUsage
Copy link
Collaborator

@jr jr Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment block associated with the await this.persistGpt5Metadata(reasoningMessage) section below the new code? (Or if not what?)

Copy link
Collaborator Author

@mrubens mrubens Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question... kind of feels like the model just left an irrelevant comment at some point

// to ensure usage data is captured even when the stream is interrupted. The background task
// uses local variables to accumulate usage data before atomically updating the shared state.

// Complete the reasoning message if it exists
// We can't use say() here because the reasoning message may not be the last message
// (other messages like text blocks or tool uses may have been added after it during streaming)
if (reasoningMessage) {
const lastReasoningIndex = findLastIndex(
this.clineMessages,
(m) => m.type === "say" && m.say === "reasoning",
)

if (lastReasoningIndex !== -1 && this.clineMessages[lastReasoningIndex].partial) {
this.clineMessages[lastReasoningIndex].partial = false
await this.updateClineMessage(this.clineMessages[lastReasoningIndex])
}
}

await this.persistGpt5Metadata(reasoningMessage)
await this.saveClineMessages()
await this.providerRef.deref()?.postStateToWebview()
Expand Down