fix: enable 1M context window for Claude 3.5 Sonnet models #8418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for claude-sonnet-4-5 (Claude 3.5 Sonnet) in Anthropic provider's 1M context check - Added Claude 3.5 Sonnet model IDs to BEDROCK_1M_CONTEXT_MODEL_IDS array - Added comprehensive tests for both Anthropic and Bedrock providers - Fixes issue where Claude 3.5 Sonnet showed 200K instead of 1M tokens when 1M context was enabled Fixes #8417
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| @@ -0,0 +1 @@ | |||
| Subproject commit 2c31616e8ade2a3995c3beda2d32d82fac17bf93 | |||
Contributor
Author
There was a problem hiding this comment.
P1: This appears to be an unintended submodule/temp artifact. Please remove tmp-pr-8415/Roo-Code from the PR to avoid introducing stray submodules/files.
| @@ -0,0 +1 @@ | |||
| Subproject commit 815444000508f67c41ba51175f1d3061364ea0bc | |||
Contributor
Author
There was a problem hiding this comment.
P1: This looks like another unintended submodule/temp artifact. Please remove tmp/pr-8380-Roo-Code from the PR.
| if ( | ||
| provider === "anthropic" && | ||
| id === "claude-sonnet-4-20250514" && | ||
| (id === "claude-sonnet-4-20250514" || id === "claude-sonnet-4-5") && |
Contributor
Author
There was a problem hiding this comment.
P3: Minor maintainability suggestion — model ID checks for 1M context (e.g., 'claude-sonnet-4-20250514' and 'claude-sonnet-4-5') could be centralized into a small set/constant to simplify future additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where Claude 3.5 Sonnet models were not displaying the correct 1M token context window in the UI when the "Enable 1M context window" option was enabled.
Problem
When using Claude 3.5 Sonnet (claude-sonnet-4-5) with the "Enable 1M context window" option enabled:
Solution
Changes
Testing
Screenshots
N/A - This is a backend logic fix that affects the displayed token count in the UI.
Fixes #8417
Important
Fixes UI to correctly display 1M context window for Claude 3.5 Sonnet models in Anthropic and Bedrock providers.
getSelectedModel()inuseSelectedModel.tsto handle 1M context for Claude 3.5 Sonnet in both Anthropic and Bedrock providers.BEDROCK_1M_CONTEXT_MODEL_IDSinbedrock.ts.getSelectedModel()to apply 1M context for Anthropic provider whenanthropicBeta1MContextis true.useSelectedModel.spec.tsto verify 1M context window behavior for both Anthropic and Bedrock providers.This description was created by
for 3b22cd0. You can customize this summary. It will automatically update as commits are pushed.