refactor(history): store task history in external file #8524
Conversation
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| try { | ||
| const taskHistoryUri = vscode.Uri.joinPath(this.globalStorageUri, "taskHistory.jsonl") | ||
| const fileContent = await vscode.workspace.fs.readFile(taskHistoryUri) | ||
| const lines = fileContent.toString().split("\n").filter(Boolean) |
There was a problem hiding this comment.
P0: fileContent is a Uint8Array; calling toString() returns "[object Uint8Array]" in Node, breaking JSONL parsing and causing an empty history. Decode the buffer first.
| const lines = fileContent.toString().split("\n").filter(Boolean) | |
| const lines = new TextDecoder("utf-8").decode(fileContent).split("\n").filter(Boolean) |
| try { | ||
| const taskHistoryUri = vscode.Uri.joinPath(this.globalStorageUri, "taskHistory.jsonl") | ||
| const content = tasks.map((task) => JSON.stringify(task)).join("\n") + "\n" | ||
| await vscode.workspace.fs.writeFile(taskHistoryUri, Buffer.from(content)) |
There was a problem hiding this comment.
P2: Atomicity/consistency: writing directly to the final file risks partial writes and bypasses our atomic write conventions. If we keep JSONL, write to a temp file then rename to the target to approximate an atomic replace.
| await vscode.workspace.fs.writeFile(taskHistoryUri, Buffer.from(content)) | |
| const tmpUri = vscode.Uri.joinPath(this.globalStorageUri, "taskHistory.jsonl.tmp") | |
| await vscode.workspace.fs.writeFile(tmpUri, Buffer.from(content)) | |
| await vscode.workspace.fs.rename(tmpUri, taskHistoryUri, { overwrite: true }) |
| }, | ||
| workspace: { | ||
| fs: { | ||
| readFile: vi.fn().mockRejectedValue(Object.assign(new Error("FileNotFound"), { code: "FileNotFound" })), |
There was a problem hiding this comment.
P2: Missing positive-path coverage: readFile is always mocked to reject, so readTaskHistoryFile's success path (decoding and parsing JSONL) is never exercised. Add a test case that resolves readFile with a valid Uint8Array (e.g., new TextEncoder().encode('{"id":"1"}\n')) and assert that taskHistory is populated.
hannesrudolph
added
the
Issue/PR - Triage
2 participants
temporary, this is for Hannes to try out