forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature/ctrl enter send #8556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Feature/ctrl enter send #8556
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
71ac954
new: Ctrl+Enter to send message to chat draft
lmtr0 9d206cb
fix(Ctrl+Enter to send): UI Setting now actually saves the setting
lmtr0 4055525
Merge branch 'main' into feature/ctrl-enter-send
lmtr0 50f03f8
feat(Ctrl+Enter to send): translations for other languages
lmtr0 4821071
feat(Ctrl+Enter to send): compatibility with macos
lmtr0 a370dd5
feat(Ctrl+Enter to send): added tests for setting
lmtr0 4351df6
Merge branch 'feature/ctrl-enter-send' of https://github.com/lmtr0/ro…
lmtr0 33112b2
feat(Ctrl+Enter to send): added missing translations
lmtr0 abd20bc
feat: add Cmd to label
lmtr0 9422644
fix(Ctrl+Enter to send): removing incorrect change from roomote
lmtr0 9df6fea
Merge branch 'main' into feature/ctrl-enter-send
lmtr0 0897c67
refactor: addressing pr comments made in #8556
lmtr0 5a83af3
Merge branch 'feature/ctrl-enter-send' of https://github.com/lmtr0/ro…
lmtr0 cad2e54
Update webview-ui/src/i18n/locales/de/settings.json
lmtr0 52c83bc
Update webview-ui/src/i18n/locales/it/settings.json
lmtr0 a1c41ea
Update webview-ui/src/i18n/locales/fr/settings.json
lmtr0 0d538a9
Update webview-ui/src/i18n/locales/fr/settings.json
lmtr0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Setting change doesn't propagate to the webview. The extension updates global state but doesn't notify the frontend, so Chat won't reflect the new behavior until a later state refresh. After updating, also post a message back to the webview so ExtensionStateContext can update immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am following the other UI checkbox; the other doesn't do this, so I believe this one shouldn't either.