fix: handle global region correctly for Vertex AI Claude models #8573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add custom baseURL for global region to use aiplatform.googleapis.com - Prevents incorrect hostname construction (global-aiplatform.googleapis.com) - Add comprehensive test coverage for global region scenarios Fixes #8571
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // For the "global" region, we need to use a custom base URL | ||
| // The default would be "global-aiplatform.googleapis.com" which is incorrect | ||
| // The correct endpoint for global is "aiplatform.googleapis.com" | ||
| const baseURL = region === "global" ? `https://aiplatform.googleapis.com/v1` : undefined // Let the SDK use its default for other regions |
Author
There was a problem hiding this comment.
[P2] Region comparison is exact-match; a user-provided value like "Global" or trailing whitespace would miss this branch. Consider normalizing before compare.
Suggested change
| const baseURL = region === "global" ? `https://aiplatform.googleapis.com/v1` : undefined // Let the SDK use its default for other regions | |
| const baseURL = region.trim().toLowerCase() === "global" ? `https://aiplatform.googleapis.com/v1` : undefined // Let the SDK use its default for other regions |
| // For the "global" region, we need to use a custom base URL | ||
| // The default would be "global-aiplatform.googleapis.com" which is incorrect | ||
| // The correct endpoint for global is "aiplatform.googleapis.com" | ||
| const baseURL = region === "global" ? `https://aiplatform.googleapis.com/v1` : undefined // Let the SDK use its default for other regions |
Author
There was a problem hiding this comment.
[P2] Verify SDK behavior regarding baseURL path: if the Vertex SDK appends "/v1" internally, this string may yield a double "/v1/v1". If so, prefer host-only.
Suggested change
| const baseURL = region === "global" ? `https://aiplatform.googleapis.com/v1` : undefined // Let the SDK use its default for other regions | |
| const baseURL = region.trim().toLowerCase() === "global" ? `https://aiplatform.googleapis.com` : undefined // Let the SDK use its default for other regions |
| }) | ||
| }) | ||
|
|
||
| it("should use custom baseURL for global region with JSON credentials", () => { |
Author
There was a problem hiding this comment.
[P3] Consider complementary tests for non-global regions with JSON credentials and with key files to assert baseURL remains undefined. This guards against regressions in the credential branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where using Google's Vertex AI provider with the "global" region and Claude models resulted in 404 errors due to incorrect hostname construction.
Problem
When the region is set to "global", the AnthropicVertex SDK was constructing the URL as
global-aiplatform.googleapis.cominstead of the correctaiplatform.googleapis.com.Solution
baseURLwhen the region is "global"https://aiplatform.googleapis.com/v1) is used for global regionTesting
Changes
src/api/providers/anthropic-vertex.tsto handle global regionsrc/api/providers/__tests__/anthropic-vertex.spec.tsFixes #8571
Important
Fixes global region handling in
AnthropicVertexHandlerby setting correctbaseURLfor Vertex AI Claude models and adds tests for verification.AnthropicVertexHandlerby settingbaseURLtohttps://aiplatform.googleapis.com/v1.anthropic-vertex.spec.tsfor global region with default, JSON credentials, and key file authentication.anthropic-vertex.ts: Adds logic for custombaseURLfor global region.anthropic-vertex.spec.ts: Adds test cases for global region handling.This description was created by
for e0fd25a. You can customize this summary. It will automatically update as commits are pushed.