Skip to content

fix: Use relative paths in scanner and file-watcher to avoid filterin… #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+73 −3
Open

fix: Use relative paths in scanner and file-watcher to avoid filterin… #8604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0864c
fix: Use relative paths in scanner and file-watcher to avoid filterin…
yavpungggi Oct 10, 2025
529a7d5
test: Add support for processing files under hidden parent directorie…
yavpungggi Oct 10, 2025
8d035a5
test: Enhance FileWatcher to process files in hidden parent directories
yavpungggi Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/services/code-index/processors/file-watcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,12 @@ export class FileWatcher implements IFileWatcher {
*/
async processFile(filePath: string): Promise<FileProcessingResult> {
try {
// Calculate relative path for ignore checks
const relativeFilePath = generateRelativeFilePath(filePath, this.workspacePath)

// Check if file is in an ignored directory
if (isPathInIgnoredDirectory(filePath)) {
// Use relative path to avoid filtering out workspaces under hidden parent directories
if (isPathInIgnoredDirectory(relativeFilePath)) {
return {
path: filePath,
status: "skipped" as const,
Expand All @@ -518,7 +522,6 @@ export class FileWatcher implements IFileWatcher {
}

// Check if file should be ignored
const relativeFilePath = generateRelativeFilePath(filePath, this.workspacePath)
if (
!this.ignoreController.validateAccess(filePath) ||
(this.ignoreInstance && this.ignoreInstance.ignores(relativeFilePath))
Expand Down
3 changes: 2 additions & 1 deletion src/services/code-index/processors/scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ export class DirectoryScanner implements IDirectoryScanner {
const relativeFilePath = generateRelativeFilePath(filePath, scanWorkspace)

// Check if file is in an ignored directory using the shared helper
if (isPathInIgnoredDirectory(filePath)) {
// Use relative path to avoid filtering out workspaces under hidden parent directories
if (isPathInIgnoredDirectory(relativeFilePath)) {
return false
}

Expand Down