-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Configure per-configuration temperature #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
3011dff to
5a24542
Compare
5a24542 to
bc9773f
Compare
Suggestion from Matt Co-authored-by: Matt Rubens <[email protected]>
| }}> | ||
| <VSCodeCheckbox | ||
| checked={isCustomTemperature} | ||
| onChange={(e: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the checkbox is toggled on and the current temperature value is undefined, nothing is set. Consider providing a default value (e.g., 0.5) so that enabling custom temperature immediately shows a sensible slider value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the behavior we want - mainly because of how we're relying on the value to toggle checkbox on or off
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Nice! |
|
Awesome! Test-driving this locally - when I check the box and try to drag the slider around to configure the temperature, I notice it is very laggy (to the extent that it takes some time to settle after I finish dragging it.) Might be worth a quick check to see if you can repro this since it's a bit unexpected re UI behavior |
Maybe we need a debounce in these slider callbacks? |
ooh thanks for trying this out. Do you see this for other sliders we have in our settings as well? or just this one? |
|
Just this one; for example, the slider to adjust the post-write delay does
not have this issue. The checkbox for `Use custom temperature` does not
have the issue either - just, very specifically, the slider. I've now
managed to make the slider completely fritz out, where it will keep
bouncing between two positions on the bar (and oddly enough, toggling and
untoggling the checkbox as it does so.)
…On Sat, Feb 8, 2025 at 11:47 AM Joe Manley ***@***.***> wrote:
Awesome! Test-driving this locally - when I check the box and try to drag
the slider around to configure the temperature, I notice it is very laggy
(to the extent that it takes some time to settle after I finish dragging
it.) Might be worth a quick check to see if you can repro this since it's a
bit unexpected re UI behavior
ooh thanks for trying this out. Do you see this for other sliders we have
in our settings as well? or just this one?
—
Reply to this email directly, view it on GitHub
<#863 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4NBSEQ7D7X6IEDGLDEHFPL2OYYLDAVCNFSM6AAAAABWXJN75SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBVHAZTQMBQGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I have sonnet selected through OR and I am able to select a temp of 2 but sonnet only allows for 0 < x < 1. |
Good catch - will take a look at this now. |
|
#912 As a follow up, I think we should audit our input boxes - or just add a tiny bit of more delay and introduce a loader. |


Description
Screen.Recording.2025-02-09.at.8.21.55.PM.mov
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Adds per-configuration model temperature settings with UI support and tests.
modelTemperatureoption toApiHandlerOptionsinapi.tsfor configuring model temperatures.AnthropicHandler,AwsBedrockHandler,GeminiHandler, etc., to usemodelTemperaturewith a default fallback.TemperatureControlcomponent inTemperatureControl.tsxfor UI temperature configuration.TemperatureControlinApiOptions.tsxto allow users to set model temperature.TemperatureControlinTemperatureControl.test.tsxto verify UI behavior.This description was created by
for d4b7a60. It will automatically update as commits are pushed.