Skip to content

Conversation

@Githubguy132010
Copy link

@Githubguy132010 Githubguy132010 commented Oct 13, 2025

Replace instances of VSCodeTextField with a new PasswordInputField component for API key inputs across multiple provider components, enhancing password visibility toggling and accessibility. Remove unused imports related to VSCodeTextField.

Fixes #8638

- Replaced VSCodeTextField with PasswordInputField for API key inputs across multiple provider components (Bedrock, Cerebras, Chutes, DeepInfra, DeepSeek, Doubao, Featherless, Fireworks, Gemini, Glama, Groq, HuggingFace, IOIntelligence, LiteLLM, Mistral, Moonshot, Ollama, OpenAI, OpenAICompatible, OpenRouter, Requesty, SambaNova, Unbound, VercelAiGateway, XAI, ZAi).
- Introduced a new PasswordInputField component to handle password visibility toggling and improved accessibility.
- Updated imports and adjusted props accordingly to maintain functionality and styling.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Oct 13, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 13, 2025
Githubguy132010

This comment was marked as resolved.

@Githubguy132010
Copy link
Author

Fix confirmed. Works. Ready for review.

@Githubguy132010 Githubguy132010 changed the title Refactor API Key Inputs to Use PasswordInputField Component fix: Refactor API Key Inputs to Use PasswordInputField Component Oct 13, 2025
@brunobergher
Copy link
Collaborator

Looks good UX-wise 👍

@roomote
Copy link

roomote bot commented Oct 24, 2025

Rooviewer Clock   See task on Roo Cloud

Review Complete ✅

No new issues found. The merge from main does not introduce any problems. The previously identified API callback signature issue remains resolved.

Previous reviews

Mention @roomote to ask your PR Fixer agent to address the feedback.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Oct 29, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - Needs Preliminary Review size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: PR [Needs Prelim Review]

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add eye icon in the Settings > Providers > API Key

3 participants