fix: show message instead of empty popover for current checkpoint restore button #8648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=80&v=4){kind=small}
…tore button - Added message display when trying to restore the current checkpoint - Fixed empty popover issue reported in #8646 - Added 'alreadyCurrent' translation key to English locale
dosubot
bot
added
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "cannotUndo": "This action cannot be undone.", | ||
| "restoreFilesAndTaskDescription": "Restores your project's files back to a snapshot taken at this point and deletes all messages after this point." | ||
| "restoreFilesAndTaskDescription": "Restores your project's files back to a snapshot taken at this point and deletes all messages after this point.", | ||
| "alreadyCurrent": "This checkpoint is already current" |
There was a problem hiding this comment.
The message for "alreadyCurrent" is missing a period at the end. For consistency with other messages in this file (e.g., "cannotUndo"), consider adding a full stop.
Suggested change
| "alreadyCurrent": "This checkpoint is already current" | |
| "alreadyCurrent": "This checkpoint is already current." |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "cannotUndo": "Aksi ini tidak dapat dibatalkan.", | ||
| "restoreFilesAndTaskDescription": "Mengembalikan file proyek kamu ke snapshot yang diambil pada titik ini dan menghapus semua pesan setelah titik ini." | ||
| "restoreFilesAndTaskDescription": "Mengembalikan file proyek kamu ke snapshot yang diambil pada titik ini dan menghapus semua pesan setelah titik ini.", | ||
| "alreadyCurrent": "This checkpoint is already current" |
There was a problem hiding this comment.
The new key "alreadyCurrent" is currently using English text in an Indonesian locale file. If this is unintended, please update it to an Indonesian translation for consistency. Otherwise, consider adding a comment clarifying the mixed language usage.
Suggested change
| "alreadyCurrent": "This checkpoint is already current" | |
| "alreadyCurrent": "Checkpoint ini sudah menjadi yang terbaru" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address Issue #8646 where the restore button for the last/current checkpoint shows an empty floating window.
Problem
When clicking the restore button on a checkpoint marked as "current", the popover opens but displays no content, resulting in an empty floating window that confuses users.
Solution
Changes
CheckpointMenu.tsxto show appropriate content for current checkpointsalreadyCurrenttranslation key toen/chat.jsonTesting
Fixes #8646
Feedback and guidance are welcome!
Important
Fixes empty popover issue for current checkpoint restore button by adding a message and restructuring content in
CheckpointMenu.tsx.CheckpointMenu.tsx, added a message "This checkpoint is already current" for current checkpoints to prevent empty popover.alreadyCurrenttranslation key toen/chat.jsonand 19 other locale files.CheckpointMenu.tsx.This description was created by
for 8ed8186. You can customize this summary. It will automatically update as commits are pushed.