feat: add chat message font size setting #8680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=80&v=4){kind=small}
- Add chatMessageFontSize property to ExtensionState and GlobalSettings - Add UI dropdown in settings with 5 size options (Default, Extra Small, Small, Large, Extra Large) - Apply font size scaling to ChatRow component (90%, 95%, 100%, 105%, 110%) - Add message handler to persist the setting - Include tests for the new functionality Users can now control the font size for chat messages in ChatView/Virtuoso content without affecting other UI elements
dosubot
bot
added
size:L
Code Review Summary✅ No issues found - This PR is ready to merge! The implementation successfully adds a chat message font size setting with clean integration across all layers: Changes Verified
Implementation Quality
This feature allows users to adjust chat message readability without affecting other UI elements. Great work! 🎉 |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| setIncludeTaskHistoryInEnhance((newState as any).includeTaskHistoryInEnhance) | ||
| } | ||
| // Update chatMessageFontSize if present in state message | ||
| if ((newState as any).chatMessageFontSize !== undefined) { |
There was a problem hiding this comment.
Review: The new state property 'chatMessageFontSize' is added; consider improving type safety instead of using 'as any' in the update block.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new setting that allows users to control the font size specifically for chat messages in the ChatView component (Virtuoso content), without affecting other UI elements.
Changes
User Impact
Users can now adjust the readability of chat messages to their preference without affecting other parts of the interface. The setting is accessible through Settings > UI Settings > Chat Message Font Size.
Testing
Review Confidence: 92%
Implementation has been reviewed and meets all requirements with high quality code following project patterns.
Important
Adds a chat message font size setting to the ChatView component, allowing users to adjust font size via a new dropdown in UI settings.
chatMessageFontSizesetting toExtensionStateandGlobalSettings.UISettingsfor font size with options: Default, Small, Extra Small, Large, Extra Large.ChatRowusing CSS.ExtensionStateContextto includechatMessageFontSizeand its setter.UISettingsinSettingsView.chatMessageFontSizetoChatRowandChatViewfor rendering.UISettings.fontsize.spec.tsxto verify dropdown options and state handling.UISettings.spec.tsxto include font size setting tests.This description was created by
for d6334b9. You can customize this summary. It will automatically update as commits are pushed.