-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(deps): update dependency mammoth to v1.11.0 [security] #8714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review UpdateThis PR still mixes the mammoth security update with extensive unrelated feature changes. Issues Found
Security Update✅ The mammoth dependency update from 1.9.1 to 1.11.0 correctly addresses CVE-2025-11849 (Directory Traversal vulnerability). Additional ChangesThe PR includes:
These additions should be reviewed separately from the security fix. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
8d46845 to
f1d157d
Compare
| mammoth: | ||
| specifier: ^1.9.1 | ||
| version: 1.9.1 | ||
| version: 1.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is labeled as a security update for the mammoth dependency, but includes substantial unrelated changes (new reviewer page, docs-extractor refactoring, Task.ts behavioral changes, CHANGELOG updates, locale updates). Mixing security updates with feature changes makes it harder to review and validate the security fix. Consider separating these into distinct PRs: one for the security update only, and separate PRs for the feature additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. This PR mixes security updates with unrelated feature changes, which should be separated for clearer review and validation.
f1d157d to
3219209
Compare
Review complete. This is a clean security update that correctly addresses CVE-2025-11849 by updating mammoth from 1.9.1 to 1.11.0. The PR only contains lockfile changes with no code modifications. No issues found. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
c6b4f59 to
348dc7f
Compare
348dc7f to
ab9f3bc
Compare
ab9f3bc to
ed54000
Compare
This PR contains the following updates:
1.9.1->1.11.0GitHub Vulnerability Alerts
CVE-2025-11849
Versions of the package mammoth from 0.3.25 and before 1.11.0; versions of the package mammoth from 0.3.25 and before 1.11.0; versions of the package mammoth before 1.11.0; versions of the package org.zwobble.mammoth:mammoth before 1.11.0 are vulnerable to Directory Traversal due to the lack of path or file type validation when processing a docx file containing an image with an external link (r:link attribute instead of embedded r:embed). The library resolves the URI to a file path and after reading, the content is encoded as base64 and included in the HTML output as a data URI. An attacker can read arbitrary files on the system where the conversion is performed or cause an excessive resources consumption by crafting a docx file that links to special device files such as /dev/random or /dev/zero.
Release Notes
mwilliamson/mammoth.js (mammoth)
v1.11.0Compare Source
v1.10.0Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.