-
Notifications
You must be signed in to change notification settings - Fork 2.4k
test #8741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #8741
Conversation
This reverts commit d64e677.
Review SummaryFound duplicate schema entries that need to be removed:
These duplicates were introduced during the revert and should be cleaned up to avoid redundancy in the schema definitions. |
|
Meant for my fork, sorry |
| lmStudioSchema.merge(z.object({ apiProvider: z.literal("lmstudio") })), | ||
| geminiSchema.merge(z.object({ apiProvider: z.literal("gemini") })), | ||
| geminiCliSchema.merge(z.object({ apiProvider: z.literal("gemini-cli") })), | ||
| geminiCliSchema.merge(z.object({ apiProvider: z.literal("gemini-cli") })), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate schema entry. The geminiCliSchema is added twice here, which is redundant. Remove one of the duplicate lines.
| ...lmStudioSchema.shape, | ||
| ...geminiSchema.shape, | ||
| ...geminiCliSchema.shape, | ||
| ...geminiCliSchema.shape, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate schema entry. The geminiCliSchema.shape is added twice here, which is redundant. Remove one of the duplicate lines.
This reverts commit d64e677.
Related GitHub Issue
Closes: #
Roo Code Task Context (Optional)
Description
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch