-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: add optional Roo loading animation #8748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional jumping kangaroo animation as an alternative to the default spinner in progress indicators. Users can toggle this in Settings > UI. Implementation: - Created KangarooLoader component with inline SVG (0.7s bounce animation) - Updated ProgressIndicator to conditionally render based on user preference - Added "Use Jumping Kangaroo Animation" toggle in UI Settings - Implemented full state persistence across extension and webview Changes: - New component: webview-ui/src/components/chat/KangarooLoader.tsx - Updated: webview-ui/src/components/chat/ProgressIndicator.tsx - Updated: webview-ui/src/components/settings/UISettings.tsx - Updated: webview-ui/src/components/settings/SettingsView.tsx - Updated: webview-ui/src/context/ExtensionStateContext.tsx - Updated: src/shared/WebviewMessage.ts - Updated: src/shared/ExtensionMessage.ts - Updated: src/core/webview/webviewMessageHandler.ts - Updated: packages/types/src/global-settings.ts The kangaroo icon is an inline SVG (no external dependencies), ensuring fast rendering and perfect scaling. Default remains the standard spinner to maintain existing UX.
…s with translation keys:
Replaced hardcoded strings with translation keys:
Label: {t("settings:ui.kangarooAnimation.label")}
Description: {t("settings:ui.kangarooAnimation.description")}
Added translations for all the i8n locales (translated with ChatGPT-5).
Contributor
✅ Review Complete - No Issues FoundThis PR has been reviewed and no issues were identified. The implementation is clean and follows best practices: What Was Reviewed
SummaryThe kangaroo loading animation feature is well-implemented with:
This PR is ready to merge. Great work! 🦘 |
Collaborator
|
@brunobergher can we have this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue - Needs Approval
Ready to move forward, but waiting on maintainer or team sign-off.
size:L
This PR changes 100-499 lines, ignoring generated files.
UI/UX
UI/UX related or focused
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #8747
Roo Code Task Context (Optional)
Description
This PR adds an optional jumping kangaroo animation as an alternative to the default spinner in progress indicators. Users can toggle this preference in Settings > UI section.
Key implementation details:
KangarooLoader Component (
webview-ui/src/components/chat/KangarooLoader.tsx)currentColorfor theme compatibilityState Management
useKangarooAnimation: booleanto GlobalSettings schemaUI Integration
Test Procedure
Test setting persistence:
Test animation in action:
Test theme compatibility:
Pre-Submission Checklist
Screenshots / Videos
Video of the UI settings toggle and the animation showing in the different chat-related components:
Close-up demo:
Also works nice with light mode:
Documentation Updates
No documentation updates are required.
Rationale: This is a self-explanatory UI setting that users can discover in Settings. No changes to user-facing documentation needed.
Additional Notes
The kangaroo SVG path is inline (not an external asset) for optimal performance
Animation duration of 0.7s was chosen based on testing for smooth, non-distracting motion
Default remains the standard spinner to avoid surprising existing users
This aligns with "Enhanced User Experience" from the roadmap by giving users UI customization options
Get in Touch
Discord: lillelord9379
Important
Adds an optional kangaroo animation for progress indicators, allowing users to switch from the default spinner, with updates to UI components, state management, and i18n.
KangarooLoadercomponent inKangarooLoader.tsxfor a jumping kangaroo animation as an alternative to the default spinner.currentColorfor theme compatibility.useKangarooAnimationboolean inglobal-settings.tsandClineProvider.tsfor state persistence.ExtensionState.ProgressIndicator.tsxconditionally renders kangaroo animation based on user setting.SettingsView.tsxandUISettings.tsx.This description was created by
for 52c1b95. You can customize this summary. It will automatically update as commits are pushed.