Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 23, 2025

Description

This PR addresses Issue #8791 by adding a top-level toggle for the concurrent/multi-file edits feature (MULTI_FILE_APPLY_DIFF experiment) that was previously buried in experimental settings.

Changes

  • Added a "Concurrent Edits" toggle in the AutoApproveDropdown component
  • Toggle is positioned above the regular auto-approval settings for easy access
  • Connected toggle to the MULTI_FILE_APPLY_DIFF experiment state management
  • Added appropriate localization strings
  • Implemented proper TypeScript types and message handling

Implementation Details

The toggle:

  • Displays in the Auto-Approve dropdown for quick access
  • Uses the existing ToggleSwitch UI component
  • Includes a tooltip explaining its purpose
  • Synchronizes with the experiment state via ExtensionState context
  • Properly communicates state changes via vscode.postMessage

Testing

  • ✅ TypeScript compilation passes
  • ✅ ESLint checks pass
  • ✅ Existing toggle-switch tests pass
  • ✅ Manual testing of toggle functionality

Screenshots/Demo

The new toggle appears at the top of the Auto-Approve dropdown, making it easily accessible without navigating to experimental settings.

Fixes #8791


Important

Adds a "Concurrent Edits" toggle to AutoApproveDropdown, connects it to experiment state, and updates localization in multiple languages.

  • Behavior:
    • Adds "Concurrent Edits" toggle to AutoApproveDropdown for easy access.
    • Connects toggle to MULTI_FILE_APPLY_DIFF experiment state.
    • Uses ToggleSwitch component with tooltip and state synchronization via ExtensionState context.
    • Communicates state changes via vscode.postMessage.
  • Localization:
    • Adds localization strings for "Concurrent Edits" in chat.json for ca, de, en, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW.
  • Testing:
    • TypeScript compilation and ESLint checks pass.
    • Existing toggle-switch tests pass.
    • Manual testing of toggle functionality.

This description was created by Ellipsis for 234cc3a. You can customize this summary. It will automatically update as commits are pushed.

- Add a top-level toggle for the MULTI_FILE_APPLY_DIFF experiment
- Display toggle in AutoApproveDropdown above regular auto-approval settings
- Connect toggle to experiment state management
- Add localization strings for the new toggle
- Implement proper TypeScript types and message handling

Fixes #8791
@roomote roomote bot requested review from cte, jr and mrubens as code owners October 23, 2025 15:13
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Oct 23, 2025
@roomote
Copy link
Author

roomote bot commented Oct 23, 2025

Code Review Summary

No issues found. The implementation is solid:

✅ Type safety with proper optional chaining and nullish coalescing
✅ Components correctly imported and used
✅ State management follows existing patterns
✅ Localization properly implemented
✅ Message handling correctly communicates state changes
✅ Null safety handled appropriately

The concurrent edits toggle is appropriately independent of the main auto-approval system.

Translation Update Review:

✅ All 17 locale files properly updated with concurrent edits translations
✅ JSON structure is correct and consistent across all locales
✅ Translations are appropriate and accurate for each language
✅ Proper placement within the autoApprove section


Follow Along on Roo Code Cloud

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 23, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph
Copy link
Collaborator

If you turn these on or off midway through a task you will likely break the apply_diff file edits for that session as models seem to take queues on how to edit files not only from the tool instructions but also from the previous edits made within that chat/task session. Basically, this would cause major instability on the chat. Closing for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Top-level Toggle for Concurrent/Multi-file Edits

3 participants