-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add concurrent edits toggle to auto-approval dropdown #8793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add a top-level toggle for the MULTI_FILE_APPLY_DIFF experiment - Display toggle in AutoApproveDropdown above regular auto-approval settings - Connect toggle to experiment state management - Add localization strings for the new toggle - Implement proper TypeScript types and message handling Fixes #8791
Code Review SummaryNo issues found. The implementation is solid: ✅ Type safety with proper optional chaining and nullish coalescing The concurrent edits toggle is appropriately independent of the main auto-approval system. Translation Update Review: ✅ All 17 locale files properly updated with concurrent edits translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
|
If you turn these on or off midway through a task you will likely break the apply_diff file edits for that session as models seem to take queues on how to edit files not only from the tool instructions but also from the previous edits made within that chat/task session. Basically, this would cause major instability on the chat. Closing for this reason. |
Description
This PR addresses Issue #8791 by adding a top-level toggle for the concurrent/multi-file edits feature (MULTI_FILE_APPLY_DIFF experiment) that was previously buried in experimental settings.
Changes
Implementation Details
The toggle:
Testing
Screenshots/Demo
The new toggle appears at the top of the Auto-Approve dropdown, making it easily accessible without navigating to experimental settings.
Fixes #8791
Important
Adds a "Concurrent Edits" toggle to
AutoApproveDropdown, connects it to experiment state, and updates localization in multiple languages.AutoApproveDropdownfor easy access.MULTI_FILE_APPLY_DIFFexperiment state.ToggleSwitchcomponent with tooltip and state synchronization viaExtensionStatecontext.vscode.postMessage.chat.jsonforca,de,en,es,fr,hi,id,it,ja,ko,nl,pl,pt-BR,ru,tr,vi,zh-CN,zh-TW.This description was created by
for 234cc3a. You can customize this summary. It will automatically update as commits are pushed.