Skip to content

fix: respect nested .gitignore files in search_files #8804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: respect nested .gitignore files in search_files #8804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/services/ripgrep/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,15 @@ export async function regexSearchFiles(
throw new Error("Could not find ripgrep binary")
}

const args = ["--json", "-e", regex, "--glob", filePattern || "*", "--context", "1", "--no-messages", directoryPath]
const args = ["--json", "-e", regex]

// Only add --glob if a specific file pattern is provided
// Using --glob "*" overrides .gitignore behavior, so we omit it when no pattern is specified
if (filePattern) {
args.push("--glob", filePattern)
}

args.push("--context", "1", "--no-messages", directoryPath)

let output: string
try {
Expand Down