fix: keep pinned models fixed at top of scrollable list #8813
+125
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separated pinned and unpinned configs into different containers - Pinned configs now stay fixed at the top - Only unpinned configs are scrollable - Added tests to verify the fixed behavior Fixes #8812
dosubot
bot
added
size:L
Review SummaryAll previously identified issues have been resolved. The refactored implementation using CSS sticky positioning is much cleaner and more maintainable than the previous dynamic height calculation approach.
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
|
Success, looks good |
2 tasks
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
- Changed sticky header background from bg-vscode-editorWidget-background to bg-vscode-dropdown-background to match popover container - Moved separator logic into sticky container as conditional bottom border to prevent scroll artifacts - Updated tests to match new separator structure - All 21 tests passing
daniel-lxs
approved these changes
Nov 4, 2025
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Nov 5, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #8812. Feedback and guidance are welcome.
Problem
When the model list is long enough to scroll, the pinned models at the top scroll away with the rest of the list, which defeats the purpose of pinning them for quick access.
Solution
Changes
ApiConfigSelector.tsxto render pinned items in a fixed container and unpinned items in a scrollable containerTesting
Screenshots:
Before
After
Fixes #8812
Important
Fixes pinned models scrolling issue by separating pinned and unpinned models in
ApiConfigSelector.tsx, ensuring pinned models remain fixed.ApiConfigSelector.tsx.ApiConfigSelector.spec.tsxto verify pinned models remain fixed and unpinned models scroll.This description was created by
for 93c1b6f. You can customize this summary. It will automatically update as commits are pushed.