Skip to content

fix: resolve checkpoint menu popover overflow #8867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
Merged

fix: resolve checkpoint menu popover overflow #8867

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ae883e
fix: resolve checkpoint menu popover overflow
daniel-lxs Oct 27, 2025
1865268
fix: update PopoverContent mock to handle className prop
daniel-lxs Oct 27, 2025
ba556cf
refactor: remove redundant whitespace-nowrap classes
daniel-lxs Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webview-ui/src/components/chat/checkpoints/CheckpointMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,11 @@ export const CheckpointMenu = ({ ts, commitHash, checkpoint, onOpenChange }: Che
</Button>
</PopoverTrigger>
</StandardTooltip>
<PopoverContent align="end" container={portalContainer}>
<PopoverContent align="end" container={portalContainer} className="w-auto min-w-max">
<div className="flex flex-col gap-2">
<Button
variant="secondary"
className="whitespace-nowrap"
Copy link

@roomote roomote bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace-nowrap class is redundant here because it's already included in the base buttonVariants definition (see webview-ui/src/components/ui/button.tsx line 8). While this doesn't cause any functional issues due to how Tailwind handles duplicate classes, it's unnecessary duplication that could confuse future maintainers.

onClick={() => {
onDiffFromInit()
setMoreOpen(false)
Expand All @@ -186,6 +187,7 @@ export const CheckpointMenu = ({ ts, commitHash, checkpoint, onOpenChange }: Che
</Button>
<Button
variant="secondary"
className="whitespace-nowrap"
Copy link

@roomote roomote bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here - the whitespace-nowrap class is redundant because it's already included in the base buttonVariants definition (see webview-ui/src/components/ui/button.tsx line 8).

onClick={() => {
onDiffWithCurrent()
setMoreOpen(false)
Expand Down
6 changes: 5 additions & 1 deletion webview-ui/src/components/chat/checkpoints/__tests__/CheckpointSaved.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ vi.mock("@/components/ui", () => {
)
},
PopoverTrigger: ({ children }: any) => <div data-testid="popover-trigger">{children}</div>,
PopoverContent: ({ children }: any) => <div data-testid="popover-content">{children}</div>,
PopoverContent: ({ children, className, ...rest }: any) => (
<div data-testid="popover-content" className={className} {...rest}>
{children}
</div>
),
}
})

Expand Down