Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 27, 2025

Description

This PR fixes an issue where the condensing API configuration dropdown was not visible in the Context Management settings, causing the selection to reset to "Global Default (all profiles)" after navigating away.

Problem

As reported in #8871:

  • The "API Configuration for Context Condensing" dropdown was missing from the Context Management settings
  • Users' API configuration selections would reset after leaving the settings page
  • The system would use the wrong API provider (e.g., Gemini instead of OpenRouter) when condensing context

Solution

  • Added the dropdown to the component
  • Made the dropdown always visible, regardless of the "Automatically trigger intelligent context condensing" checkbox state
  • Updated to pass the prop to the component
  • Updated unit tests to account for the additional dropdown element

Technical Details

The backend already had full support for using the selected condensing API configuration (verified in lines 1006-1081). The issue was purely in the UI layer where the dropdown was missing from the Context Management settings component.

Testing

  • ✅ All unit tests pass
  • ✅ Manual testing confirms the dropdown is now visible and persists selections
  • ✅ The selected API configuration is properly used for context condensing operations

Fixes #8871


Important

Fixes visibility and persistence of condensing API configuration dropdown in Context Management settings.

  • UI Fix:
    • Added condensing API configuration dropdown to ContextManagementSettings.tsx.
    • Made dropdown always visible, independent of "Automatically trigger intelligent context condensing" checkbox.
    • Updated SettingsView.tsx to pass condensingApiConfigId prop to ContextManagementSettings.
  • Testing:
    • Updated ContextManagementSettings.spec.tsx to include tests for the new dropdown and its visibility.
    • Ensured tests check for persistence of dropdown selection and correct API usage.

This description was created by Ellipsis for bcbcd20. You can customize this summary. It will automatically update as commits are pushed.

- Added condensingApiConfigId dropdown to ContextManagementSettings component
- Dropdown is now visible regardless of auto-condense checkbox state
- Updated SettingsView to pass condensingApiConfigId prop
- Fixed test expectations to account for new dropdown element

Fixes #8871
@roomote roomote bot requested review from cte, jr and mrubens as code owners October 27, 2025 23:49
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Oct 27, 2025
@roomote
Copy link
Author

roomote bot commented Oct 27, 2025

Review Complete ✅

I've reviewed this PR and found no issues. The implementation correctly:

  • Adds the condensing API configuration dropdown to the Context Management settings
  • Makes the dropdown always visible (not conditional on auto-condense checkbox)
  • Uses existing translation keys from the prompts:supportPrompts.condense namespace
  • Properly passes the condensingApiConfigId prop through the component tree
  • Updates tests to reflect the additional dropdown element (2 comboboxes instead of 1)
  • Follows established patterns for state management and vscode messaging

The fix directly addresses the reported issue where the API configuration selection was not visible and would reset after navigation.

Follow Along on Roo Code Cloud

Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@jmalmo
Copy link

jmalmo commented Oct 28, 2025

The fix works 👍 Settings persist, and it is nice that the dropdown is always showing now.

One thing that should be adjusted is that there are too much air space above and beneath the checkbox setting "Automatically trigger intelligent context condensing":

Skjermbilde 2025-10-28 kl  01 36 05 Skjermbilde 2025-10-28 kl  01 34 12

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Oct 29, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: PR [Needs Prelim Review]

Development

Successfully merging this pull request may close these issues.

[BUG] API Configuration for Context Condensing” resets to *Global Default* and condensing uses the wrong provider

4 participants