fix: detect newly added folders in workspace dynamically #8887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added workspace folder change listener in extension.ts - Convert codeIndexManagers from array to Map for better tracking - Implement logic to create CodeIndexManager for added folders - Implement logic to dispose CodeIndexManager for removed folders - Add handleWorkspaceFoldersChanged method to ClineProvider - Fixes #8886
dosubot
bot
added
size:M
PR Review CompleteI've reviewed the changes in this pull request that adds dynamic workspace folder detection. Issues Found
SummaryThe implementation approach is sound, but there's a critical ordering issue that will cause the code to fail at runtime when workspace folders change. The listener registration needs to be moved after the provider initialization. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+133
to
+165
| context.subscriptions.push( | ||
| vscode.workspace.onDidChangeWorkspaceFolders(async (event) => { | ||
| // Handle removed folders | ||
| for (const removedFolder of event.removed) { | ||
| const manager = codeIndexManagers.get(removedFolder.uri.fsPath) | ||
| if (manager) { | ||
| outputChannel.appendLine( | ||
| `[CodeIndexManager] Error during background CodeIndexManager configuration/indexing for ${folder.uri.fsPath}: ${error.message || error}`, | ||
| `[CodeIndexManager] Removing CodeIndexManager for removed folder: ${removedFolder.uri.fsPath}`, | ||
| ) | ||
| // Dispose the manager | ||
| manager.dispose() | ||
| // Remove from our map | ||
| codeIndexManagers.delete(removedFolder.uri.fsPath) | ||
| // Remove from context subscriptions | ||
| const index = context.subscriptions.indexOf(manager) | ||
| if (index > -1) { | ||
| context.subscriptions.splice(index, 1) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| context.subscriptions.push(manager) | ||
| // Handle added folders | ||
| for (const addedFolder of event.added) { | ||
| outputChannel.appendLine( | ||
| `[CodeIndexManager] Adding CodeIndexManager for new folder: ${addedFolder.uri.fsPath}`, | ||
| ) | ||
| await initializeCodeIndexManagerForFolder(addedFolder) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Notify the provider about workspace changes | ||
| provider.handleWorkspaceFoldersChanged() | ||
| }), | ||
| ) |
There was a problem hiding this comment.
The provider variable is referenced before it's initialized. The workspace folder change listener (lines 133-165) calls provider.handleWorkspaceFoldersChanged() on line 163, but provider is not created until line 168. This will cause a ReferenceError when workspace folders are added or removed. The listener registration should be moved to after the provider initialization, or the provider reference should be captured differently.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #8886 where RooCode fails to detect newly added folders in an existing workspace.
Problem
When users add a new folder to their current VS Code workspace, RooCode does not automatically recognize it. The extension continues to behave as if the folder does not exist, meaning any files inside the new folder are ignored and unavailable for interaction.
Solution
Implemented dynamic workspace folder detection by:
onDidChangeWorkspaceFoldersAPIcodeIndexManagersfrom array to Map for efficient O(1) folder trackingChanges
handleWorkspaceFoldersChangedmethod to update stateTesting
Fixes #8886
Important
Adds dynamic detection of newly added folders in VS Code workspace by managing
CodeIndexManagerinstances and updatingClineProviderstate.onDidChangeWorkspaceFoldersAPI.codeIndexManagersfrom array toMapfor efficient folder tracking.CodeIndexManagerinstances for added and removed folders.ClineProviderto update workspace path and refresh webview state.src/extension.ts: Implements workspace folder change listener and managesCodeIndexManagerinstances.src/core/webview/ClineProvider.ts: AddshandleWorkspaceFoldersChangedmethod to update state.This description was created by
for eb36d95. You can customize this summary. It will automatically update as commits are pushed.