Skip to content

Conversation

@cexer
Copy link

@cexer cexer commented Feb 9, 2025

Description

Some providers do not recognize content of the form content: [{xxx}, {xxx}], for example:

Related issue #769,related discussion #839
This PR fix content being an array by splitting it into multiple string messages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Apply a deepseek configuration to the roo code with APIKEY and model id from ByteDance Volcano Engine (https://console.volcengine.com/ark/region:ark+cn-beijing/openManagement)
  2. Select Volcano Engine's deepseek in the roo code and test Ask, the model can respond normally. Before this fix, it will response "One or more parameters invalid ...".
  3. Also tested other providers + models, including Chat/Image Input model, all ok.

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: b002a2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@mrubens mrubens moved this from PR [Unverified] to PR [Deferred] in Roo Code Roadmap Mar 10, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 10, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 10, 2025

Hi @cexer, I made some changes to support the Ark provider here: #886. Does that help at all with this PR?

@cexer cexer closed this Mar 15, 2025
@github-project-automation github-project-automation bot moved this from PR [Deferred] to Done in Roo Code Roadmap Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants