forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: disable Gemini grounding for code generation to preserve array indices #8918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,52 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl | |
| : new GoogleGenAI({ apiKey }) | ||
| } | ||
|
|
||
| /** | ||
| * Detects if the conversation context suggests code generation. | ||
| * This helps prevent Gemini's grounding feature from incorrectly | ||
| * removing array indices like [0] which it may interpret as citations. | ||
| */ | ||
| private isCodeGenerationContext(messages: Anthropic.Messages.MessageParam[]): boolean { | ||
| // Keywords that strongly suggest code generation | ||
| const codeKeywords = [ | ||
| "create.*(?:file|script|function|class|method|code|program)", | ||
| "write.*(?:file|script|function|class|method|code|program)", | ||
| "generate.*(?:file|script|function|class|method|code|program)", | ||
| "implement.*(?:function|class|method|algorithm)", | ||
| "python file", | ||
| "javascript file", | ||
| "typescript file", | ||
| "code snippet", | ||
| "code example", | ||
| "def\\s+\\w+\\s*\\(", // Python function definition | ||
| "function\\s+\\w+\\s*\\(", // JavaScript function | ||
| "class\\s+\\w+", // Class definition | ||
| "\\[\\d+\\]", // Array index patterns | ||
| "array\\[", | ||
| "list\\[", | ||
| "fruits\\[0\\]", // Specific to the reported issue | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This pattern is redundant as it's already covered by the more general |
||
| ] | ||
|
|
||
| const codePattern = new RegExp(codeKeywords.join("|"), "i") | ||
|
|
||
| // Check recent messages for code-related content | ||
| const recentMessages = messages.slice(-5) // Check last 5 messages | ||
|
|
||
| for (const message of recentMessages) { | ||
| if (Array.isArray(message.content)) { | ||
| for (const block of message.content) { | ||
| if (block.type === "text" && codePattern.test(block.text)) { | ||
| return true | ||
| } | ||
| } | ||
| } else if (typeof message.content === "string" && codePattern.test(message.content)) { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| async *createMessage( | ||
| systemInstruction: string, | ||
| messages: Anthropic.Messages.MessageParam[], | ||
|
|
@@ -74,7 +120,10 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl | |
| tools.push({ urlContext: {} }) | ||
| } | ||
|
|
||
| if (this.options.enableGrounding) { | ||
| // Only enable grounding if it's not a code generation context | ||
| // This prevents Gemini from misinterpreting array indices like [0] as citation markers | ||
| const isCodeContext = this.isCodeGenerationContext(messages) | ||
| if (this.options.enableGrounding && !isCodeContext) { | ||
| tools.push({ googleSearch: {} }) | ||
| } | ||
|
|
||
|
|
@@ -217,7 +266,13 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl | |
| if (this.options.enableUrlContext) { | ||
| tools.push({ urlContext: {} }) | ||
| } | ||
| if (this.options.enableGrounding) { | ||
|
|
||
| // Check if the prompt suggests code generation | ||
| const isCodeContext = this.isCodeGenerationContext([ | ||
| { role: "user", content: [{ type: "text", text: prompt }] }, | ||
| ]) | ||
|
|
||
| if (this.options.enableGrounding && !isCodeContext) { | ||
| tools.push({ googleSearch: {} }) | ||
| } | ||
| const promptConfig: GenerateContentConfig = { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern is overly broad and will incorrectly match citation-style references in regular text (e.g., "see reference [1]" or "table [2] shows results"), causing grounding to be disabled for non-code contexts where users discuss numbered references or citations. Consider removing this pattern or making it more specific to code contexts by requiring surrounding code syntax.