fix: improve Claude Code authentication error handling #8952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dedicated authentication error message in i18n translations - Detect authentication errors in Claude Code provider and run.ts - Provide helpful instructions for users to authenticate with 'claude login' - Add comprehensive tests for authentication error detection Fixes #8946
dosubot
bot
added
the
size:L
Review SummaryI've reviewed the changes in this PR and identified the following issue: Issues to Address
|
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+193
to
+209
| private isAuthenticationError(message: string): boolean { | ||
| const authErrorPatterns = [ | ||
| "authentication failed", | ||
| "unauthorized", | ||
| "not authenticated", | ||
| "login required", | ||
| "invalid api key", | ||
| "api key expired", | ||
| "credential", | ||
| "auth error", | ||
| "403", | ||
| "401", | ||
| ] | ||
|
|
||
| const lowerMessage = message.toLowerCase() | ||
| return authErrorPatterns.some((pattern) => lowerMessage.includes(pattern)) | ||
| } |
There was a problem hiding this comment.
The isAuthenticationError() function is duplicated here and in src/integrations/claude-code/run.ts (lines 290-308) with inconsistent pattern lists. The run.ts version includes two additional patterns: "please authenticate" and "claude login". Consider extracting this to a shared utility function to maintain consistency and reduce duplication.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves error handling for Claude Code CLI authentication failures, addressing Issue #8946 where users were unable to login to Claude Code CLI v2.0.30.
Problem
Users were experiencing authentication failures with Claude Code CLI v2.0.30 on Windows, receiving generic error messages that didn't provide clear guidance on how to resolve the issue.
Solution
This PR implements:
claude loginTesting
Changes
src/i18n/locales/en/common.jsonsrc/api/providers/claude-code.tssrc/integrations/claude-code/run.tssrc/api/providers/__tests__/claude-code.spec.tsFixes #8946
Important
Improves authentication error handling in Claude Code CLI with better detection, user-friendly messages, and comprehensive pattern matching.
claude-code.tsandrun.ts.isAuthenticationError()function to detect patterns like '401', '403', 'unauthorized', etc.common.jsonwith user-friendly guidance for authentication failures.claude-code.spec.ts.runClaudeCode()inrun.tsto handle authentication errors in stderr or error output.authenticationErrormessage incommon.jsonfor i18n support.This description was created by
for 4204fc5. You can customize this summary. It will automatically update as commits are pushed.