Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Nov 1, 2025

Updated English locale copy to explicitly state: "Set to 0 to disable this safety mechanism (it will never trigger)." Change made in settings.json. Tests: webview-ui Vitest suite passes. Lint and type checks pass via turbo. Non-functional i18n-only change.


Important

Clarifies that setting consecutiveMistakeLimit to 0 disables the safety mechanism in multiple locale files.

  • Behavior:
    • Updates description for consecutiveMistakeLimit in settings.json across multiple locales to clarify that setting to 0 disables the safety mechanism.
  • Locales:
    • Changes made in en, ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW.
  • Testing:
    • Webview-ui Vitest suite passes.
    • Lint and type checks pass via turbo.

This description was created by Ellipsis for 263414e. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners November 1, 2025 19:25
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 1, 2025
@roomote
Copy link
Author

roomote bot commented Nov 1, 2025

See this task on Roo Code Cloud

Review complete. All 17 locale translations correctly implement the clarification text for setting consecutiveMistakeLimit to 0.

Previous Reviews

Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 1, 2025
@hannesrudolph
Copy link
Collaborator

@roomote please internationalize this.

@roomote
Copy link
Author

roomote bot commented Nov 3, 2025

See this task on Roo Code Cloud

Working on internationalizing the clarification text about setting consecutiveMistakeLimit to 0 across all locale files.

Implementation Plan

  1. Add clarification text to all locale files: Append the translated version of "Set to 0 to disable this safety mechanism (it will never trigger)." to the consecutiveMistakeLimit.description field in each locale file:
    • French (fr)
    • Japanese (ja)
    • Spanish (es)
    • German (de)
    • Korean (ko)
    • Chinese Simplified (zh-CN)
    • Portuguese Brazil (pt-BR)
    • Russian (ru)
    • Italian (it)
    • Dutch (nl)
    • Polish (pl)
    • Vietnamese (vi)
    • Chinese Traditional (zh-TW)
    • Turkish (tr)
    • Catalan (ca)
    • Hindi (hi)
    • Indonesian (id)

The change will maintain consistency with the English version while providing appropriate translations for each language.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Nov 3, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Nov 3, 2025
- Updated all locale files to include translation for '0 disables' clarification
- Covers 17 additional locales (ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW)
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 3, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: PR [Needs Review]

Development

Successfully merging this pull request may close these issues.

5 participants