forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: add tiered pricing support for models with different token tier rates #8984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+260
−74
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
921cc45
fix: add tiered pricing support for models with different token tier …
roomote 5e34db1
fix: correct test structure and tiered pricing logic
roomote 7cfe770
fix: update tiered pricing for Gemini 2.5 Pro, Sonnet 4/4.5, and Qwen…
roomote 389524d
test: update OpenRouter test snapshots for tiered pricing
roomote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
describeblocks for tiered pricing tests are incorrectly nested inside the previousit()block (line 207 "should handle missing cache prices"). Test frameworks like Vitest do not executedescribeblocks nested withinit()blocks, so these tests are never actually running. This explains why the PR reports all tests passing despite the new test suites being added. These test suites should be moved outside and placed as siblings to the other test blocks within the "calculateApiCostAnthropic" and "calculateApiCostOpenAI" describe blocks respectively.