feat: add performance warning for gpt5-codex model #8985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add performanceWarning field to ModelInfo type schema - Add warning message to gpt-5-codex model definition - Display warning in ApiOptions and ModelPicker components - Warning advises users to use standard GPT-5 models for better tool call performance Fixes #8983
dosubot
bot
added
the
size:S
|
Review complete. No issues found. The implementation correctly adds the Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
dosubot
bot
added
enhancement
2 tasks
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a user-facing warning when the gpt5-codex model is selected, informing users that it performs poorly with Roo's tool call functionality and suggesting they use standard GPT-5 models instead.
Changes
performanceWarningfield to theModelInfotype schema to support model-specific warningsgpt-5-codexmodel definitionApiOptionsandModelPickercomponents to display performance warningsApiErrorMessagecomponent for consistencyRelated Issue
Fixes #8983
Testing
Screenshots
The warning message reads: "GPT-5-Codex performs poorly with Roo's tool call functionality. Consider using standard GPT-5 models instead for better performance."
This warning appears in both the main settings view and the model picker component.
Important
Adds a performance warning for the
gpt-5-codexmodel, displayed inApiOptionsandModelPickerusingApiErrorMessage, with schema updates inmodel.tsand model definition inopenai.ts.performanceWarningfield toModelInfoschema inmodel.ts.gpt-5-codexmodel inopenai.ts.ApiOptions.tsxandModelPicker.tsxusingApiErrorMessage.gpt-5-codex.This description was created by
for 912803c. You can customize this summary. It will automatically update as commits are pushed.