Skip to content

feat: add performance warning for gpt5-codex model #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: add performance warning for gpt5-codex model #8985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/types/src/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ export const modelInfoSchema = z.object({
cachableFields: z.array(z.string()).optional(),
// Flag to indicate if the model is deprecated and should not be used
deprecated: z.boolean().optional(),
// Performance warning message to display when this model is selected
performanceWarning: z.string().optional(),
// Flag to indicate if the model is free (no cost)
isFree: z.boolean().optional(),
/**
Expand Down
2 changes: 2 additions & 0 deletions packages/types/src/providers/openai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ export const openAiNativeModels = {
outputPrice: 10.0,
cacheReadsPrice: 0.13,
description: "GPT-5-Codex: A version of GPT-5 optimized for agentic coding in Codex",
performanceWarning:
"GPT-5-Codex performs poorly with Roo's tool call functionality. Consider using standard GPT-5 models instead for better performance.",
supportsVerbosity: true,
supportsTemperature: false,
},
Expand Down
5 changes: 5 additions & 0 deletions webview-ui/src/components/settings/ApiOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,11 @@ const ApiOptions = ({
<ApiErrorMessage errorMessage={t("settings:validation.modelDeprecated")} />
)}

{/* Show performance warning if model has one */}
{selectedModelInfo?.performanceWarning && !selectedModelInfo.deprecated && (
<ApiErrorMessage errorMessage={selectedModelInfo.performanceWarning} />
)}

{selectedProvider === "bedrock" && selectedModelId === "custom-arn" && (
<BedrockCustomArn
apiConfiguration={apiConfiguration}
Expand Down
3 changes: 3 additions & 0 deletions webview-ui/src/components/settings/ModelPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ export const ModelPicker = ({
{selectedModelInfo?.deprecated && (
<ApiErrorMessage errorMessage={t("settings:validation.modelDeprecated")} />
)}
{selectedModelInfo?.performanceWarning && !selectedModelInfo.deprecated && (
<ApiErrorMessage errorMessage={selectedModelInfo.performanceWarning} />
)}
{selectedModelId && selectedModelInfo && !selectedModelInfo.deprecated && (
<ModelInfoView
apiProvider={apiConfiguration.apiProvider}
Expand Down