Skip to content

Don't output newline-only reasoning #8990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
+105 −2
Merged

Don't output newline-only reasoning #8990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53cafa4
Don't output newline-only reasoning
mrubens Nov 3, 2025
71f060e
test: add coverage for whitespace-only reasoning_content filtering
roomote Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/api/providers/base-openai-compatible-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,11 @@ export abstract class BaseOpenAiCompatibleProvider<ModelName extends string>
}
}

if (delta && "reasoning_content" in delta && delta.reasoning_content) {
yield { type: "reasoning", text: (delta.reasoning_content as string | undefined) || "" }
if (delta && "reasoning_content" in delta) {
const reasoning_content = (delta.reasoning_content as string | undefined) || ""
if (reasoning_content?.trim()) {
yield { type: "reasoning", text: reasoning_content }
}
}
Comment on lines +127 to 132
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change correctly filters out whitespace-only reasoning content. However, there's no test coverage for this new behavior. Consider adding a test case with reasoning_content: "\n" to verify the filtering works and prevent regression.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roomote add the test please

Copy link

@roomote roomote bot Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this task on Roo Code Cloud

Added test coverage for whitespace-only reasoning_content filtering. All local checks passed.

View commit | Revert commit


if (chunk.usage) {
Expand Down