feat: add OpenAI-compatible provider for NVIDIA and other services #9002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new OpenAiCompatibleHandler provider for generic OpenAI-compatible APIs - Add configuration support in provider-settings.ts and API index - Support custom base URLs and API keys for services like NVIDIA - Include comprehensive tests for the new provider - Fixes #8998
dosubot
bot
added
size:L
|
Review complete. Found 1 issue that should be addressed:
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+21
to
+25
| // Since ApiHandlerOptions doesn't have openAiCompatibleBaseUrl/ApiKey yet, | ||
| // we'll use the openAiBaseUrl and openAiApiKey for now as a workaround | ||
| // This will be properly fixed when we add the proper types | ||
| const baseURL = (options as any).openAiCompatibleBaseUrl || options.openAiBaseUrl | ||
| const apiKey = (options as any).openAiCompatibleApiKey || options.openAiApiKey |
There was a problem hiding this comment.
The type assertion (options as any) bypasses TypeScript's type checking. Since ApiHandlerOptions extends ProviderSettings which includes openAiCompatibleBaseUrl and openAiCompatibleApiKey (defined in provider-settings.ts lines 425-427), these properties should be directly accessible without casting. The fallback to openAiBaseUrl/openAiApiKey creates ambiguity about which properties are authoritative for this provider.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #8998 by adding support for generic OpenAI-compatible APIs like NVIDIA.
Summary
Adds a new
openai-compatibleprovider that allows users to connect to any OpenAI-compatible API endpoint by specifying a custom base URL and API key. This enables support for services like NVIDIA API and other OpenAI-compatible services that use the same protocol.Changes
OpenAiCompatibleHandlerthat extends the base OpenAI-compatible provider classopenAiCompatibleBaseUrlandopenAiCompatibleApiKeysettings in provider-settings.tsTesting
Example Usage
Users can now use NVIDIA API or any OpenAI-compatible service by:
https://integrate.api.nvidia.com/v1)minimaxai/minimax-m2)Fixes #8998
Feedback and guidance are welcome!
Important
Add
OpenAiCompatibleHandlerfor OpenAI-compatible APIs, including NVIDIA, with configuration, API integration, UI support, and tests.OpenAiCompatibleHandlerinopenai-compatible.tsfor OpenAI-compatible APIs.openAiCompatibleBaseUrlandopenAiCompatibleApiKeyinprovider-settings.ts.providerSettingsSchemaDiscriminatedandproviderSettingsSchemato include new settings.OpenAiCompatibleHandlerinindex.ts.buildApiHandler()to handleopenai-compatibleprovider.openai-compatibleinuseSelectedModel.ts.openai-compatible.spec.tsfor testingOpenAiCompatibleHandler.modelIdKeysByProviderandMODELS_BY_PROVIDERinprovider-settings.ts.This description was created by
for 14fbf0b. You can customize this summary. It will automatically update as commits are pushed.