Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Nov 4, 2025

This PR attempts to address Issue #9015 where queued messages were blocking the entire conversation.

Problem

Users reported that when messages get queued, they cannot:

  • Delete queued messages (actually this was already possible via individual delete buttons)
  • Edit queued messages (actually this was already possible by clicking on them)
  • Start new tasks (this was the main issue - queued messages blocked all interaction)

Solution

  1. Allow new tasks to bypass the queue: Modified ChatView.tsx to detect when a user is starting a new task (no existing messages) and allow it to proceed even when there are queued messages.

  2. Added "Clear All" button: Enhanced the QueuedMessages component with a bulk delete option to clear all queued messages at once.

Changes

  • Modified ChatView.tsx to check if this is a new task and bypass queue restrictions
  • Added "Clear All" button to QueuedMessages.tsx component
  • Implemented clearAll() method in MessageQueueService
  • Added webview message handler for clearQueuedMessages
  • Updated WebviewMessage type definitions

Testing

  • TypeScript compilation passes
  • All existing tests pass
  • Linting passes

Fixes #9015

Feedback and guidance are welcome!


Important

Allows new tasks to bypass queued messages and adds a "Clear All" button to clear queued messages in ChatView.tsx and QueuedMessages.tsx.

  • Behavior:
    • ChatView.tsx: Allows new tasks to bypass queued messages by checking if there are no existing messages.
    • QueuedMessages.tsx: Adds a "Clear All" button to remove all queued messages at once.
  • Functions:
    • clearAll() in MessageQueueService.ts: Clears all messages and emits a state change.
    • webviewMessageHandler.ts: Handles clearQueuedMessages to invoke clearAll().
  • Types:
    • WebviewMessage.ts: Adds clearQueuedMessages to WebviewMessage type.
  • Testing:
    • TypeScript compilation, existing tests, and linting pass.

This description was created by Ellipsis for f81bf71. You can customize this summary. It will automatically update as commits are pushed.

- Modified ChatView to detect and allow new tasks even when messages are queued
- Added "Clear All" button to QueuedMessages component for bulk deletion
- Implemented clearAll() method in MessageQueueService
- Added webview message handler for clearQueuedMessages
- Updated WebviewMessage type definitions

Fixes #9015
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 4, 2025 12:22
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Nov 4, 2025
@roomote
Copy link
Author

roomote bot commented Nov 4, 2025

See this task on Roo Code Cloud

Review Complete

No issues found. The implementation correctly addresses the queued message blocking problem:

  • New task bypass logic properly checks message history length
  • Clear All button integration is clean and functional
  • Backend service changes are minimal and correct
  • Type definitions properly updated

The PR successfully resolves issue #9015.

Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.

vscode.postMessage({ type: "clearQueuedMessages" })
}}
className="text-xs">
{t("queuedMessages.clearAll", "Clear All")}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove inline fallback string in the translation call. Use translation keys defined in external language files rather than providing 'Clear All' as a fallback inline.

Suggested change
{t("queuedMessages.clearAll", "Clear All")}
{t("queuedMessages.clearAll")}

This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Once there is a Queued message, any request maynot get treated

3 participants