fix: allow new tasks to bypass queued messages and add clear all button #9016
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified ChatView to detect and allow new tasks even when messages are queued - Added "Clear All" button to QueuedMessages component for bulk deletion - Implemented clearAll() method in MessageQueueService - Added webview message handler for clearQueuedMessages - Updated WebviewMessage type definitions Fixes #9015
dosubot
bot
added
size:M
Review CompleteNo issues found. The implementation correctly addresses the queued message blocking problem:
The PR successfully resolves issue #9015. Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| vscode.postMessage({ type: "clearQueuedMessages" }) | ||
| }} | ||
| className="text-xs"> | ||
| {t("queuedMessages.clearAll", "Clear All")} |
There was a problem hiding this comment.
Remove inline fallback string in the translation call. Use translation keys defined in external language files rather than providing 'Clear All' as a fallback inline.
Suggested change
| {t("queuedMessages.clearAll", "Clear All")} | |
| {t("queuedMessages.clearAll")} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9015 where queued messages were blocking the entire conversation.
Problem
Users reported that when messages get queued, they cannot:
Solution
Allow new tasks to bypass the queue: Modified
ChatView.tsxto detect when a user is starting a new task (no existing messages) and allow it to proceed even when there are queued messages.Added "Clear All" button: Enhanced the
QueuedMessagescomponent with a bulk delete option to clear all queued messages at once.Changes
ChatView.tsxto check if this is a new task and bypass queue restrictionsQueuedMessages.tsxcomponentclearAll()method inMessageQueueServiceclearQueuedMessagesWebviewMessagetype definitionsTesting
Fixes #9015
Feedback and guidance are welcome!
Important
Allows new tasks to bypass queued messages and adds a "Clear All" button to clear queued messages in
ChatView.tsxandQueuedMessages.tsx.ChatView.tsx: Allows new tasks to bypass queued messages by checking if there are no existing messages.QueuedMessages.tsx: Adds a "Clear All" button to remove all queued messages at once.clearAll()inMessageQueueService.ts: Clears all messages and emits a state change.webviewMessageHandler.ts: HandlesclearQueuedMessagesto invokeclearAll().WebviewMessage.ts: AddsclearQueuedMessagestoWebviewMessagetype.This description was created by
for f81bf71. You can customize this summary. It will automatically update as commits are pushed.