forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
hotfix: serialize resumptions to prevent cancel+restore race condition #9025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+125
−9
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/core/webview/__tests__/webviewMessageHandler.resume-gating.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { describe, it, expect, vi, beforeEach } from "vitest" | ||
| import { webviewMessageHandler } from "../webviewMessageHandler" | ||
|
|
||
| describe("webviewMessageHandler - resume gating on checkpointRestore", () => { | ||
| let mockProvider: any | ||
|
|
||
| beforeEach(() => { | ||
| vi.clearAllMocks() | ||
|
|
||
| const mockCline = { | ||
| isInitialized: true, | ||
| checkpointRestore: vi.fn().mockResolvedValue(undefined), | ||
| } | ||
|
|
||
| mockProvider = { | ||
| beginStateTransaction: vi.fn(), | ||
| endStateTransaction: vi.fn().mockResolvedValue(undefined), | ||
| setSuppressResumeAsk: vi.fn(), | ||
| cancelTask: vi.fn().mockResolvedValue(undefined), | ||
| getCurrentTask: vi.fn(() => mockCline), | ||
| } | ||
| }) | ||
|
|
||
| it("sets suppressResumeAsk around cancel + restore flow", async () => { | ||
| await webviewMessageHandler(mockProvider, { | ||
| type: "checkpointRestore", | ||
| payload: { | ||
| commitHash: "abc123", | ||
| ts: Date.now(), | ||
| mode: "restore", | ||
| }, | ||
| } as any) | ||
|
|
||
| // Ensure gating is toggled on then off | ||
| expect(mockProvider.setSuppressResumeAsk).toHaveBeenCalledWith(true) | ||
| expect(mockProvider.cancelTask).toHaveBeenCalledTimes(1) | ||
| expect(mockProvider.endStateTransaction).toHaveBeenCalledTimes(1) | ||
| expect(mockProvider.setSuppressResumeAsk).toHaveBeenLastCalledWith(false) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
endStateTransaction()throws an exception,setSuppressResumeAsk(false)on line 1057 won't execute, leaving the suppression flag permanently set totrue. This would prevent all future resume asks from being scheduled until VS Code is restarted. Nest the cleanup in a second try-finally block to guarantee the flag is always reset:Fix it with Roo Code or mention @roomote and request a fix.