Skip to content

Add test execution to pre-push hook #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add test execution to pre-push hook #9029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ else
fi

$pnpm_cmd run check-types
$pnpm_cmd run test
Copy link

@roomote roomote bot Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test command on line 20 will not block the push when tests fail. Bash continues executing after a command fails unless explicitly told to exit. The script will proceed to check changesets and complete the hook even if tests fail, allowing broken code to be pushed.

Suggested change
$pnpm_cmd run test
$pnpm_cmd run test || exit 1

Fix it with Roo Code or mention @roomote and request a fix.


# Check for new changesets.
NEW_CHANGESETS=$(find .changeset -name "*.md" ! -name "README.md" | wc -l | tr -d ' ')
Expand Down