fix: prevent shell injection in pre-push hook environment loading #9059
+10
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes shell injection vulnerability in pre-push hook environment loading.
Problem:
The original
export $(grep -v '^\#' .env.local | xargs)pattern was vulnerable to shell injection. Malicious content in .env.local likeRUN_TESTS_ON_PUSH=true; rm -rf /could execute arbitrary commands.Solution:
Uses the existing
@dotenvx/dotenvxdependency to securely parse .env.local without shell evaluation:npx dotenvx getsafely extracts specific variablesnpx dotenvx runexecutes commands with environment loaded securelySecurity Benefits: