Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 10, 2025

Before:
Screenshot 2025-02-10 at 12 00 33 PM

After:
Screenshot 2025-02-10 at 12 01 26 PM

After with error:
Screenshot 2025-02-10 at 12 01 48 PM


Important

Hide TemperatureControl in ApiOptions when fromWelcomeView is true and improve error handling in WelcomeView.

  • Behavior:
    • TemperatureControl in ApiOptions is hidden when fromWelcomeView is true.
    • WelcomeView updates error handling for the submit button, displaying error messages directly.
  • Tests:
    • Added tests in ApiOptions.test.tsx to verify TemperatureControl visibility based on fromWelcomeView prop.
  • Misc:
    • Removed unused useEffect in WelcomeView.

This description was created by Ellipsis for 439c46c. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 439c46c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Let's go!
</VSCodeButton>
{errorMessage && (
<span
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use tailwind to clean this up a bit:

<span className="text-destructive">...</span>

I'm not sure if the 12px is the base --vscode-font-size value, but you can make the text smaller or larger with text-sm, text-lg, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we might want to add some clinerules about tailwind in this repo

Copy link
Collaborator

@cte cte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@mrubens mrubens merged commit 1f07a77 into main Feb 10, 2025
6 checks passed
@mrubens mrubens deleted the welcome_screen_tweaks branch February 10, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants