Fix issue where Ollama/LMStudio URLs would flicker back to previous while entering #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: febf434 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stea9499
approved these changes
Feb 11, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
mrubens
force-pushed
the
fix_model_loading_flicker
branch
from
84d8d40 to
febf434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we try to reload the models every 2 seconds, and that causes ApiOptions to re-render. There's probably something deeper to figure out here, but checking equality before updating state seems to alleviate this.
Before:
Screen_Recording_2025-02-10_at_10.37.58_PM.mov
After:
Screen.Recording.2025-02-10.at.11.19.06.PM.mov
Important
Fix flickering issue in
ApiOptions.tsxby checking model data equality before updating state.ApiOptions.tsxby checking equality before updating state forollamaModels,lmStudioModels, andvsCodeLmModels.JSON.stringify().funny-bananas-sneeze.mdfor patch release.This description was created by
for febf434. It will automatically update as commits are pushed.