Skip to content

Bring back checkpoints on Windows #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 1 commit into from
Feb 11, 2025
Merged

Bring back checkpoints on Windows #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/Cline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export class Cline {
this.fuzzyMatchThreshold = fuzzyMatchThreshold ?? 1.0
this.providerRef = new WeakRef(provider)
this.diffViewProvider = new DiffViewProvider(cwd)
this.checkpointsEnabled = process.platform !== "win32" && !!enableCheckpoints
this.checkpointsEnabled = enableCheckpoints ?? false

if (historyItem) {
this.taskId = historyItem.id
Expand Down
4 changes: 0 additions & 4 deletions src/services/checkpoints/CheckpointService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,6 @@ export class CheckpointService {
}

public static async create({ taskId, git, baseDir, log = console.log }: CheckpointServiceOptions) {
if (process.platform === "win32") {
throw new Error("Checkpoints are not supported on Windows.")
}

git = git || simpleGit({ baseDir })

const version = await git.version()
Expand Down
14 changes: 0 additions & 14 deletions src/services/checkpoints/__tests__/CheckpointService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ describe("CheckpointService", () => {
let git: SimpleGit
let testFile: string
let service: CheckpointService
let originalPlatform: string

const initRepo = async ({
baseDir,
Expand Down Expand Up @@ -49,19 +48,6 @@ describe("CheckpointService", () => {
return { git, testFile }
}

beforeAll(() => {
originalPlatform = process.platform
Object.defineProperty(process, "platform", {
value: "darwin",
})
})

afterAll(() => {
Object.defineProperty(process, "platform", {
value: originalPlatform,
})
})

beforeEach(async () => {
const baseDir = path.join(os.tmpdir(), `checkpoint-service-test-${Date.now()}`)
const repo = await initRepo({ baseDir })
Expand Down
40 changes: 19 additions & 21 deletions webview-ui/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,29 +701,27 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
</div>
)}

{process.platform !== "win32" && (
<div style={{ marginBottom: 15 }}>
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
<span style={{ color: "var(--vscode-errorForeground)" }}>⚠️</span>
<VSCodeCheckbox
checked={checkpointsEnabled}
onChange={(e: any) => {
setCheckpointsEnabled(e.target.checked)
}}>
<span style={{ fontWeight: "500" }}>Enable experimental checkpoints</span>
</VSCodeCheckbox>
</div>
<p
style={{
fontSize: "12px",
marginTop: "5px",
color: "var(--vscode-descriptionForeground)",
<div style={{ marginBottom: 15 }}>
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
<span style={{ color: "var(--vscode-errorForeground)" }}>⚠️</span>
<VSCodeCheckbox
checked={checkpointsEnabled}
onChange={(e: any) => {
setCheckpointsEnabled(e.target.checked)
}}>
When enabled, Roo will save a checkpoint whenever a file in the workspace is
modified, added or deleted, letting you easily revert to a previous state.
</p>
<span style={{ fontWeight: "500" }}>Enable experimental checkpoints</span>
</VSCodeCheckbox>
</div>
)}
<p
style={{
fontSize: "12px",
marginTop: "5px",
color: "var(--vscode-descriptionForeground)",
}}>
When enabled, Roo will save a checkpoint whenever a file in the workspace is modified,
added or deleted, letting you easily revert to a previous state.
</p>
</div>

{Object.entries(experimentConfigsMap)
.filter((config) => config[0] !== "DIFF_STRATEGY")
Expand Down
Loading