Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 11, 2025

This fixes some buggy logic around the overlap between rate limiting and exponential backoff.

New logic:

  • Only show the rate limiting countdown if the request is not a retry
  • If the request is a retry, make sure that the delay is at least as long as the rate limit

Important

Fixes retry delay logic in Cline.ts to prevent overlapping with rate limiting and ensures correct countdown messaging.

  • Behavior:
    • Fixes logic in Cline.ts to ensure rate limiting countdown is only shown if the request is not a retry.
    • Ensures retry delay is at least as long as the rate limit delay.
  • Tests:
    • Adds test in Cline.test.ts to verify retry delay is not applied twice.
    • Verifies countdown messages are shown correctly during retries.

This description was created by Ellipsis for 052903b. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 052903b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrubens mrubens force-pushed the fix_retry_delay_bugs branch from e111ee1 to 052903b Compare February 11, 2025 16:20
)
})

it("should not apply retry delay twice", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test for 'should not apply retry delay twice' repeats the delay countdown verification logic. Consider extracting a helper function to verify countdown messages to reduce redundancy and ease maintenance.

@mrubens mrubens merged commit a3bb0ed into main Feb 11, 2025
5 of 6 checks passed
@mrubens mrubens deleted the fix_retry_delay_bugs branch February 11, 2025 16:31
refactorthis pushed a commit to refactorthis/Roo-Code that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants