-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Checkpoints logging tweaks + defensive catches #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| try { | ||
| await this.git.add(["-A"]) | ||
| const status = await this.git.status() | ||
| this.log(`[saveCheckpoint] status: ${JSON.stringify(status)}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logging was too verbose.
| throw new Error( | ||
| `[saveCheckpoint] Failed in stash commit phase: ${err instanceof Error ? err.message : String(err)}`, | ||
| ) | ||
| if (!stashCommit) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't generate a stash commit then there are no changes to store in a checkpoint. This has handled by the diff step below, but we can short circuit that.
| ) | ||
|
|
||
| // Escalate to a forced checkout if we can't checkout the | ||
| // main branch under nor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this get cut off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I think I lost my train of thought while writing that 😂
Store initial checkpoint
Description
I improved the logging for the Windows locked file cases that I tested.
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Enhance checkpoint functionality with metadata, improved error handling, and updated UI components for better user interaction.
checkpointparameter tosay()inCline.tsto include checkpoint metadata in messages.checkpointDiff(),checkpointSave(), andcheckpointRestore()inCline.ts.restoreMain()andsaveCheckpoint()inCheckpointService.ts.ChatRow.tsxandCheckpointMenu.tsxto display checkpoint metadata and handle user interactions.checkpointSchemainschema.tsto validate checkpoint metadata.CheckpointSaved.tsxto usecheckpointSchemafor metadata validation.CheckpointService.test.tsto verify checkpoint creation, restoration, and error handling.This description was created by
for 94cb09f. It will automatically update as commits are pushed.