Fix file revert on abort #949
Conversation
|
| const stream = this.attemptApiRequest(previousApiReqIndex) // yields only if the first chunk is successful, otherwise will allow the user to retry the request (most likely due to rate limit error, which gets thrown on the first chunk) | ||
| let assistantMessage = "" | ||
| let reasoningMessage = "" | ||
| this.isStreaming = true |
There was a problem hiding this comment.
Taken from Cline's current main.
| } | ||
| } | ||
| } finally { | ||
| this.isStreaming = false |
There was a problem hiding this comment.
Taken from Cline's current main.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| } | ||
|
|
||
| const abortStream = async (cancelReason: ClineApiReqCancelReason, streamingFailedMessage?: string) => { | ||
| console.log(`[Cline#abortStream] cancelReason = ${cancelReason}`) |
There was a problem hiding this comment.
Avoid using raw console.log for logging. Consider using a structured logging mechanism or an existing logger to ensure consistent and production-ready logs.
| console.log(`[Cline#abortStream] cancelReason = ${cancelReason}`) | |
| logger.info(`[Cline#abortStream] cancelReason = ${cancelReason}`) |
| } | ||
| } | ||
|
|
||
| async abortTask() { |
There was a problem hiding this comment.
Given the fix for file revert on abort, please add (or update) unit/integration tests covering this abort behavior to ensure regressions are caught.
Description
https://www.loom.com/share/716d1895488a44d1b69a3bbc800e462d
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Fix file revert behavior in
abortTask()inCline.tsto ensure changes are reverted correctly during task abortion, especially when streaming.abortTask()inCline.tsto ensure changes are reverted when a task is aborted.revertChanges()is called ifisStreamingandisEditingare true.abortStream()to track cancellation reasons inCline.ts.This description was created by
for 6119cb1. It will automatically update as commits are pushed.