Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 11, 2025

Description

https://www.loom.com/share/716d1895488a44d1b69a3bbc800e462d?sid=43f72e36-9475-4eda-81ea-5a589b3b9c6d

Fixes #948

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Change dialog background in dialog.tsx to match VSCode theme.

  • UI Update:
    • In dialog.tsx, change dialog background class from bg-background to bg-vscode-editor-background to match VSCode theme.

This description was created by Ellipsis for 0b8fd14. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 0b8fd14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cte
Copy link
Collaborator Author

cte commented Feb 11, 2025

Will eventually add all UI components to Storybook with a theme picker so we can verify that we're respecting themes.

@cte cte merged commit 4a86789 into main Feb 11, 2025
9 checks passed
@cte cte deleted the cte/fix-themed-background-for-dialogs branch February 11, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode on new profile

3 participants