-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Separate Settings Components #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Settings Components #967
Conversation
|
80bd9f8 to
461a153
Compare
|
Hey, thanks for the PR! I really like the improved organization but would be interested in exploring other visual treatments - have you looked at any other variations there? Happy to discuss more in Discord if that's easier. Thanks again! |
|
that looks awesaome! I was just thinking that! |
Actually, I haven't tried other visual styles yet. Since we already have the components organized in hierarchy, it should be quite easy to explore different section styles. We can complete the component set by adding But honestly, the better solution is probably to follow what Cline did - move most settings to proper VSCode extension settings that users can configure through VSCode's own UI. |
461a153 to
ec96de3
Compare
ec96de3 to
ee85628
Compare
|
Hey, thank you for your PR. The separation of settings component is already implemented on Roo Code. If you think we need to do better on our implementation please leave a comment or open a new PR. |

Description
Made some nice cleanup to the settings components by:
Separated out these components:
SettingCheckboxSettingComboSettingSliderSettingTextFieldRemoved
ExperimentalFeatureand moved its functionality intoSettingCheckboxFixed the indent guides to be consistent for all settings
Type of change
How Has This Been Tested?
Ad-hoc testing
Checklist:
Additional context
Related Issues
Reviewers
Important
Refactor settings components in the webview UI by introducing modular components and removing redundant code for improved maintainability and consistency.
SettingCheckbox,SettingCombo,SettingSlider, andSettingTextFieldcomponents for modular settings management.ExperimentalFeaturecomponent, integrated its functionality intoSettingCheckbox.ApiOptions.tsx,SettingsView.tsx, andTemperatureControl.tsxto use new components.__tests__/ApiOptions.test.tsxand__tests__/SettingsView.test.tsxto accommodate new components.This description was created by
for 35f224efe06e181125b9976a586a42fcf06350f8. It will automatically update as commits are pushed.