Skip to content

Conversation

@feifei325
Copy link
Contributor

@feifei325 feifei325 commented Feb 14, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Roo Code settings menu supports multiple languages

  • en(English)
  • zh(Simplified Chinese)

Related Issues

Reviewers


Important

Adds multilingual support using i18next, with English and Chinese translations, and updates components to utilize translation keys.

  • Multilingual Support:
    • Integrates i18next and react-i18next for multilingual support in index.tsx.
    • Adds English (en.json) and Chinese (zh.json) translations in webview-ui/src/i18n/locales/.
    • Configures language detection and fallback in i18n/index.ts.
  • Component Updates:
    • Updates components like SettingsView.tsx, PromptsView.tsx, McpView.tsx, and others to use useTranslation for text.
    • Replaces hardcoded strings with translation keys in components such as HistoryView.tsx, McpToolRow.tsx, and ApiConfigManager.tsx.
  • Dependencies:
    • Adds i18next and react-i18next to package.json dependencies.
  • Miscellaneous:
    • Updates package.json to bump typescript version.

This description was created by Ellipsis for 91aff1e. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: fd08886

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I’ll take a look at this soon. In general I haven’t thought a ton about the internationalization strategy - curious what people have seen work in the past. Just using internationalized strings when developing and letting the community translate as follow-ups?

@feifei325
Copy link
Contributor Author

Thanks for the PR! I’ll take a look at this soon. In general I haven’t thought a ton about the internationalization strategy - curious what people have seen work in the past. Just using internationalized strings when developing and letting the community translate as follow-ups?

Thanks for the response! I’m currently promoting the Roo Code plugin to my colleagues, and in order to help everyone better understand the meaning of the menu settings, I’ve implemented internationalization. I personally believe that using internationalized strings during development helps developers from different countries better understand the meaning of the menu settings.

@im47cn
Copy link
Contributor

im47cn commented Feb 24, 2025

I found a i18n ready project, https://gitee.com/coolcline/coolcline/blob/develop/assets/i18n/zh.json

@Shuai-S
Copy link

Shuai-S commented Feb 25, 2025

Great, hope to merge ASAP, everyone can better use roo through their native language.

@Shuai-S
Copy link

Shuai-S commented Mar 4, 2025

@feifei325 @mrubens @cte Hello, will this PR continue to merge?

@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@qdaxb
Copy link
Contributor

qdaxb commented Mar 7, 2025

@mrubens I see this PR has been sitting there for a while and conflicts are always occurring.
Maybe we can introducing the i18n framework and language files first, and then gradually translate them?

@mrubens
Copy link
Collaborator

mrubens commented Mar 7, 2025

Yes sorry, I would like to pick this up soon! Sorry for the conflicts. And I like @qdaxb's suggested approach.

@mrubens mrubens moved this from PR [Unverified] to PR [Deferred] in Roo Code Roadmap Mar 10, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 14, 2025

Working on this in other PRs, thank you!

@mrubens mrubens closed this Mar 14, 2025
@github-project-automation github-project-automation bot moved this from PR [Deferred] to Done in Roo Code Roadmap Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants