Fix inplace operation in DCRNN fully-connected reset and update gates #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
klane
commented
Jul 16, 2021
klane
commented
- Remove redundant sigmoid call
- Rename internal variable inputs_and_state
- Remove inplace operation
- Remove NotImplementedError
- Simplify reset and update gate size
Sigmoid is already called in the forward method on the output of _fc
Avoids setting it to x immediately afterwards
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 18.25% 18.48% +0.23%
==========================================
Files 7 7
Lines 400 395 -5
==========================================
Hits 73 73
+ Misses 327 322 -5
Continue to review full report at Codecov.
|
klane
added a commit
that referenced
this pull request
Jul 16, 2021
* Remove redundant sigmoid call * Rename internal variable inputs_and_state * Remove inplace operation * Remove NotImplementedError * Simplify reset and update gate size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.